Skip to content

layout: Scope table row-group children with TableRowGroupBuilder#58963

Open
servo-wpt-sync wants to merge 1 commit intoweb-platform-tests:masterfrom
servo:servo_export_43674
Open

layout: Scope table row-group children with TableRowGroupBuilder#58963
servo-wpt-sync wants to merge 1 commit intoweb-platform-tests:masterfrom
servo:servo_export_43674

Conversation

@servo-wpt-sync
Copy link
Copy Markdown
Collaborator

This pr adds the following changes:

  • Introduces TableRowGroupBuilder to handle row-group-scoped traversal more cleanly and explicitly.
  • Adds logic to save and restore current_row_group_index, ensuring correct behavior when processing nested row groups.
  • Prevents direct traversal of row-group children from the main table traversal flow to avoid incorrect context handling.
  • Ensures that anonymous rows created within a row group correctly inherit the row-group context.
  • Keeps existing row handling logic unchanged by continuing to delegate row-specific behavior to TableRowBuilder.

Fixes: #43660

Manual test

Run:

Run the following WPT tests to verify the changes:

./mach test-wpt --legacy \
  /_mozilla/mozilla/table_row_group_nested_anonymous_43660.html \
  /_mozilla/mozilla/table_row_group_color_inheritance_43660.html
Screenshot 2026-03-26 at 9 20 38 AM

Reviewed in servo/servo#43674

Signed-off-by: veercodeprog <veerpratap945050@gmail.com>
Copy link
Copy Markdown
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The review process for this patch is being conducted in the Servo project.

@servo-wpt-sync
Copy link
Copy Markdown
Collaborator Author

🛠 Changes from the source pull request (servo/servo#43674) can no longer be cleanly applied. Waiting for a new version of these changes downstream.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants