layout: Scope table row-group children with TableRowGroupBuilder#58963
Open
servo-wpt-sync wants to merge 1 commit intoweb-platform-tests:masterfrom
Open
layout: Scope table row-group children with TableRowGroupBuilder#58963servo-wpt-sync wants to merge 1 commit intoweb-platform-tests:masterfrom
servo-wpt-sync wants to merge 1 commit intoweb-platform-tests:masterfrom
Conversation
Signed-off-by: veercodeprog <veerpratap945050@gmail.com>
wpt-pr-bot
approved these changes
Apr 2, 2026
Collaborator
wpt-pr-bot
left a comment
There was a problem hiding this comment.
The review process for this patch is being conducted in the Servo project.
Collaborator
Author
|
🛠 Changes from the source pull request (servo/servo#43674) can no longer be cleanly applied. Waiting for a new version of these changes downstream. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pr adds the following changes:
TableRowGroupBuilderto handle row-group-scoped traversal more cleanly and explicitly.current_row_group_index, ensuring correct behavior when processing nested row groups.TableRowBuilder.Fixes: #43660
Manual test
Run:
Reviewed in servo/servo#43674