Copy value attribute into customizable combobox#58964
Merged
chromium-wpt-export-bot merged 1 commit intomasterfrom Apr 3, 2026
Merged
Copy value attribute into customizable combobox#58964chromium-wpt-export-bot merged 1 commit intomasterfrom
chromium-wpt-export-bot merged 1 commit intomasterfrom
Conversation
If an option element has a value attribute, then it should be used to copy into the text input. The label attribute is never used to copy into the text input, even if the option has no text content. This matches the behavior for appearance:auto. Bug: 453705243 Change-Id: Ib2d4b4c73c86d6ceb22cc9a13fb68081d28682f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7717823 Reviewed-by: David Baron <dbaron@chromium.org> Reviewed-by: Joey Arhar <jarhar@chromium.org> Commit-Queue: Joey Arhar <jarhar@chromium.org> Cr-Commit-Position: refs/heads/main@{#1609568}
602915e to
0fe9250
Compare
wpt-pr-bot
approved these changes
Apr 3, 2026
Collaborator
wpt-pr-bot
left a comment
There was a problem hiding this comment.
The review process for this patch is being conducted in the Chromium project.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If an option element has a value attribute, then it should be used to
copy into the text input. The label attribute is never used to copy into
the text input, even if the option has no text content. This matches the
behavior for appearance:auto.
Bug: 453705243
Change-Id: Ib2d4b4c73c86d6ceb22cc9a13fb68081d28682f6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7717823
Reviewed-by: David Baron <dbaron@chromium.org>
Reviewed-by: Joey Arhar <jarhar@chromium.org>
Commit-Queue: Joey Arhar <jarhar@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1609568}