fix: allow configuration freeze#4428
Merged
alexander-akait merged 1 commit intomasterfrom Apr 2, 2025
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
fixes #4427
Did you add tests for your changes?
Yes
If relevant, did you update the documentation?
No need
Summary
Allow to use
Object.freeze({})as a configurationDoes this PR introduce a breaking change?
No
Other information
There is a small limitation, because we modify some default options in configuration for better DX, using
Object.freeze({})prevent doing it, theoretically we can clone object, but it is has a bed perf and will don't work for all fields, also if you are usingObject.freeze({})it means you really don't want to modify something, otherwise just don't use it