Open
Conversation
sigvef
force-pushed
the
upper-slugs
branch
2 times, most recently
from
4a53027 to
5923478
Compare
Collaborator
Author
|
ping |
We seem to have relied on an implicit constraint that slugs should be uppercase. This pull request makes this constraint more explicit by carefully transforming slugs to uppercase everywhere.
This is needed to be able to specify the wikipendium.wiki app by label in places where names cannot be properly parsed to contain dots, such as when doing makemigrations.
This should probably work fine.
We currently assume that all article slugs are uppercase. However, prior to this commit, it was possible to create articles with lowercase slugs using the UI, which means that databases could at the point of this data contain invalid data, i.e. lowercased slugs. This commit introduces a data migration that uppercases all slugs, ensuring that the database is returned to a valid state.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change is