feat(atp): build directly from atp source (2/2)#44
Conversation
|
This seems like a better approach since it uses the upstream install script. This means that build scripts would not need updating for every change in the upstream repo. |
|
It looks like the workflow is failing because of cosign. Try cherry-picking this commit that avoids signing for PRs: 211db0c. |
|
I will split this PR in 2 parts. The first one will only contain everything required to build the apt-common layer. |
efb87ac to
4d7ab67
Compare
|
This PR is more concise now, it adds the building blocks to build a new winblues7 beta. That way we can iterate quickly using VMs and bare metal very soon I hope. Scripts and configs are cherry picked, that way we can remove unneeded configs when the beta is successful. |
There was a problem hiding this comment.
Pull request overview
Adds “beta” build variants for Winblues 7 images that layer in ATP content from the atp-common OCI image, and introduces a dedicated CI workflow to build/push those beta variants.
Changes:
- Added
recipe-beta.ymlandrecipe-nvidia-beta.ymlthat copy ATP-provided/system_filesfromghcr.io/winblues/atp-commonand remove the default Wayland Plasma session. - Added
.github/workflows/build-beta.ymlto build the beta recipes (PR + manual trigger) with a recipe matrix. - Updated build workflow concurrency grouping and removed the obsolete upstream commit reference workflow.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| recipes/recipe-beta.yml | New beta recipe that layers atp-common content and applies Winblues overlays/scripts. |
| recipes/recipe-nvidia-beta.yml | New NVIDIA beta recipe equivalent to the non-NVIDIA beta recipe. |
| .github/workflows/upstream-commit-info.yml | Removed scheduled workflow that maintained an upstream commit reference branch/file. |
| .github/workflows/build.yml | Adjusted concurrency group key to better separate events/refs. |
| .github/workflows/build-beta.yml | New CI workflow to build the beta recipes via matrix on PR/workflow_dispatch. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
ledif
left a comment
There was a problem hiding this comment.
LGTM. Thanks for pushing this through!
This Draft/PR adds support to build atp and export it as a docker layer image. So it can be easily layered on bazzite-dx images.
It uses directly the install process recommended by ATP, so it means less issues in case of an update.
It needs to be discussed but some config files can probably be removed from this repo unless it's wanted to override some default settings for atp.
it may be wanted to remove the default wayland sessions like kinoite7 is doing. => implemented