Skip to content

feat(atp): build directly from atp source (2/2)#44

Merged
ledif merged 6 commits intowinblues:mainfrom
AtomHare:upgrade-atp-build
Apr 23, 2026
Merged

feat(atp): build directly from atp source (2/2)#44
ledif merged 6 commits intowinblues:mainfrom
AtomHare:upgrade-atp-build

Conversation

@AtomHare
Copy link
Copy Markdown
Contributor

@AtomHare AtomHare commented Mar 28, 2026

This Draft/PR adds support to build atp and export it as a docker layer image. So it can be easily layered on bazzite-dx images.
It uses directly the install process recommended by ATP, so it means less issues in case of an update.

It needs to be discussed but some config files can probably be removed from this repo unless it's wanted to override some default settings for atp.

it may be wanted to remove the default wayland sessions like kinoite7 is doing. => implemented

@bominic27644
Copy link
Copy Markdown

This seems like a better approach since it uses the upstream install script. This means that build scripts would not need updating for every change in the upstream repo.

@AtomHare AtomHare marked this pull request as ready for review April 8, 2026 21:57
@ledif
Copy link
Copy Markdown
Member

ledif commented Apr 9, 2026

It looks like the workflow is failing because of cosign. Try cherry-picking this commit that avoids signing for PRs: 211db0c.

@AtomHare
Copy link
Copy Markdown
Contributor Author

AtomHare commented Apr 9, 2026

I will split this PR in 2 parts. The first one will only contain everything required to build the apt-common layer.
The other one (this one) will contain the rest. That way it will be easier to test if the build works without using workarounds.

@AtomHare AtomHare changed the title feat(atp): build directly from atp source feat(atp): build directly from atp source (2/2) Apr 9, 2026
@AtomHare AtomHare marked this pull request as draft April 10, 2026 10:44
@AtomHare AtomHare force-pushed the upgrade-atp-build branch from efb87ac to 4d7ab67 Compare April 22, 2026 20:02
@AtomHare
Copy link
Copy Markdown
Contributor Author

This PR is more concise now, it adds the building blocks to build a new winblues7 beta. That way we can iterate quickly using VMs and bare metal very soon I hope.

Scripts and configs are cherry picked, that way we can remove unneeded configs when the beta is successful.

@AtomHare AtomHare marked this pull request as ready for review April 22, 2026 20:13
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds “beta” build variants for Winblues 7 images that layer in ATP content from the atp-common OCI image, and introduces a dedicated CI workflow to build/push those beta variants.

Changes:

  • Added recipe-beta.yml and recipe-nvidia-beta.yml that copy ATP-provided /system_files from ghcr.io/winblues/atp-common and remove the default Wayland Plasma session.
  • Added .github/workflows/build-beta.yml to build the beta recipes (PR + manual trigger) with a recipe matrix.
  • Updated build workflow concurrency grouping and removed the obsolete upstream commit reference workflow.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
recipes/recipe-beta.yml New beta recipe that layers atp-common content and applies Winblues overlays/scripts.
recipes/recipe-nvidia-beta.yml New NVIDIA beta recipe equivalent to the non-NVIDIA beta recipe.
.github/workflows/upstream-commit-info.yml Removed scheduled workflow that maintained an upstream commit reference branch/file.
.github/workflows/build.yml Adjusted concurrency group key to better separate events/refs.
.github/workflows/build-beta.yml New CI workflow to build the beta recipes via matrix on PR/workflow_dispatch.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .github/workflows/build-beta.yml Outdated
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copy link
Copy Markdown
Member

@ledif ledif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for pushing this through!

@ledif ledif merged commit 0ee7b9d into winblues:main Apr 23, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants