Temperature usermod: update OneWire to 2.3.8#4131
Conversation
|
I do appreciate the effort but changing CRLF formatting is for the maintainers or original authors to perform. |
|
Thank you for the feedback @blazoncek. In all cases, the CRLF-terminated files were alone in a directory of otherwise LF-terminated files. So, they all look to be unintentional but I certainly don't want to offend anyone. I'll drop the line-ending commit. Would you like me to retain the commit that fixes the Temperature usermod's changelog Markdown rendering? Also, shouldn't the Temperature usermod's |
|
MD changes are fine with me. CRLF madness is a consequence of working on Win & mac systems without using a GH (changes made that not yet belong to a commit). |
5963c5a to
f45293d
Compare
|
@blazoncek I've removed the line-termination change. |
This change ensures that the dates are displayed on their own lines. Without the blank lines, many Markdown renderers will append the dates to the previous bullet point.
OneWire 2.3.8 includes stickbreaker's and garyd9's ESP32 fixes: blazoncek's fork is no longer needed
f45293d to
750a429
Compare
|
@blazoncek I rebased my feature branch on top of the current state of the |
OneWire 2.3.8 includes stickbreaker's and garyd9's ESP32 fixes, making blazoncek's fork no longer necessary.
This updates the dependency and removes the comment suggesting blazoncek's fork.
I noticed some minor issues that were unrelated to the OneWire version change, so I put them in separate commits prior to the final commit that's the focus of this pull request:
I ran
git ls-files --eol | awk '$1 == "i/crlf"'and found three other files in the codebase with CRLF endings.So, I figured I should go ahead and make the whole codebase uniformly use LF endings.
It will probably be the fastest/easiest to review if you view the diffs for each commit separately.