Skip to content

palette effect overflow fix#4435

Merged
netmindz merged 1 commit intowled:mainfrom
TripleWhy:TripleWhy/issue4425
Jan 9, 2025
Merged

palette effect overflow fix#4435
netmindz merged 1 commit intowled:mainfrom
TripleWhy:TripleWhy/issue4425

Conversation

@TripleWhy
Copy link
Copy Markdown
Contributor

I belive this fixes #4425

@TripleWhy
Copy link
Copy Markdown
Contributor Author

Note: this does replace some more 32 bit multiplications with slightly more expensive 64 bit multiplications.

@blazoncek
Copy link
Copy Markdown
Contributor

Tested and works.

@netmindz netmindz requested a review from DedeHai December 28, 2024 11:02
Comment thread wled00/FX.cpp
Copy link
Copy Markdown
Collaborator

@DedeHai DedeHai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

simple fix, approved.

@DedeHai DedeHai added this to the 0.15.1 candidate milestone Dec 29, 2024
@netmindz netmindz merged commit 709aeff into wled:main Jan 9, 2025
@netmindz netmindz added the bug label Jan 16, 2025
@netmindz netmindz mentioned this pull request May 26, 2025
25 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Palette effect will not spread palette colors across entire strip

5 participants