Respect timeouts specified per query#172
Respect timeouts specified per query#172hogjosh wants to merge 2 commits intoxerions:masterfrom hogjosh:respect_query_timeouts
Conversation
fishcakez
left a comment
There was a problem hiding this comment.
This is good except the set charset query will have :infinity timeout during handshake and we don't want to allow that.
In postgrex this is handled by always using an :infinity timeout and then doing this: https://github.com/elixir-ecto/postgrex/blob/2c026cb29c4f8e62ce1b2fec46f444fac440ff4d/lib/postgrex/protocol.ex#L487-L510
|
I fumbled through this. I'm happy to try to make additional changes. If I'm understanding correctly, there's a recursive call to I also have no idea if the "shutdown" processing is what we had in mind. |
I think we can close socket, and let existing code handle socket closing error. |
Intended to fix #162, but I might be barking up the wrong tree! Maybe I can at least get the ball rolling...