Merged
Conversation
mchf
force-pushed
the
remove-trusted-boot
branch
from
8c86dc8 to
fd3d013
Compare
|
coverage: 87.4% (+0.002%) from 87.398% — mchf:remove-trusted-boot into yast:master |
jreidinger
reviewed
Apr 22, 2026
|
|
||
| element boot_custom { STRING }? & | ||
| element generic_mbr { STRING }? & | ||
| element trusted_grub{ STRING }? & |
Member
There was a problem hiding this comment.
I would not drop it as it means that any profile that has "<trusted_grub>false</trusted_grub>" will be invalid. Just add comment that option is ignored.
Member
Author
There was a problem hiding this comment.
yes i intentionally wanted to invoke that error ... but if you think it is bad approach I'll give it back
Member
There was a problem hiding this comment.
well, issue with autoyast profiles is that when you generate it with clone, it contain all keys...so all cloned profile contained trusted_grub with false option.
jreidinger
reviewed
Apr 22, 2026
jreidinger
reviewed
Apr 23, 2026
jreidinger
approved these changes
Apr 23, 2026
|
✅ Autosubmission job #24820729949 successfully finished |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Trusted boot was silently dropped from OS TW some time ago