revert: Add required link libraries (mysys,sql)#5
Merged
ThePrez merged 1 commit intozendtech:masterfrom Jun 15, 2020
abmusse:revert-link-libraries
Merged
revert: Add required link libraries (mysys,sql)#5ThePrez merged 1 commit intozendtech:masterfrom abmusse:revert-link-libraries
ThePrez merged 1 commit intozendtech:masterfrom
abmusse:revert-link-libraries
Conversation
Initially, mysys and sql was added to link libraries to resolve undefined symbols when this storage engine was built with mariadb using cmake 3.16.0. For now we will fallback and build with cmake 3.7.2 which does not have the undefined symbols issue. Therefore we should revert the change that added mysys and sql to the link libraries.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Initially, mysys and sql was added to link libraries to resolve undefined
symbols when this storage engine was built with mariadb using cmake
3.16.0. For now we will fallback and build with cmake 3.7.2 which does
not have the undefined symbols issue. Therefore we should revert the change
that added mysys and sql to the link libraries.