[DNS] Punch blocking boats and minecarts#26
Draft
theredstoner wants to merge 6 commits intoAvanatiker:masterfrom
Draft
[DNS] Punch blocking boats and minecarts#26theredstoner wants to merge 6 commits intoAvanatiker:masterfrom
theredstoner wants to merge 6 commits intoAvanatiker:masterfrom
Conversation
In the stuckmanager, punch minecarts and boats that are within the reach distnace.
Owner
|
This is a nice idea but u have to check if u can even see the target entity i can recommend raytrace |
theredstoner
changed the title
Natan515
reviewed
Dec 31, 2020
| && getDistance(mc.player.positionVector, entity.positionVector) <= maxReach.value) { | ||
| val rotation = RotationUtils.getRotationTo(entity.positionVector, true) | ||
| setRotation(rotation) | ||
| mc.playerController.attackEntity(mc.player, entity) |
There was a problem hiding this comment.
Would u change it to the Hotbar where u got a sword and the fact it needs to be punched more than one, cus if there are a lot of boats and lag and no sword it can take forever and maybe get the player robber banding and disconnect?
Author
There was a problem hiding this comment.
I will add a check for swords. Thanks for the suggestion
Owner
|
Converted this to a draft until its done :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Punch boats and minecarts within reach distance that are blocking the highway