Conversation
|
Why ci action not running? |
|
Hmm I wonder if CI isn't liking that it came from a fork, although I haven't seen problems from other forks. Given that we want to hold this for a while, I've renamed the PR to start with |
Could you check |
Ah, no it's not, and I also can't enable it for some reason. You should have permission to push that branch here, so maybe do that instead. |
| @@ -1,5 +1,6 @@ | |||
| <Project Sdk="Microsoft.NET.Sdk"> | |||
|
|
|||
| <Sdk Name="Aspire.AppHost.Sdk" Version="9.0.0-preview.4.24477.2"/> | |||
There was a problem hiding this comment.
Can we make that a variable?
There was a problem hiding this comment.
Don't we need a fallback source configured for nuget or does it automatically fallback?
| using Aspire.Hosting; | ||
|
|
There was a problem hiding this comment.
Is this needed? If not:
| using Aspire.Hosting; |
There was a problem hiding this comment.
After upgrade to 9 preview build failed. I fixed build by adding this namespace.
There was a problem hiding this comment.
Weird, feel like that might be a breaking change - what was the error?
| @@ -1,3 +1,4 @@ | |||
| using Aspire.Hosting; | |||
There was a problem hiding this comment.
Is this needed? If not:
| using Aspire.Hosting; |
| using Aspire.Hosting; | ||
|
|
There was a problem hiding this comment.
Is this needed? If not:
| using Aspire.Hosting; |
Closes #56
This pull request includes several updates and improvements across multiple files, primarily focusing on upgrading the Aspire SDK version, removing unnecessary workload installations, and adding new NuGet configurations. Below is a summary of the most important changes:
Workflow Updates:
dotnet-ci.yml,dotnet-main.yml, anddotnet-release.ymlfiles. (.github/workflows/dotnet-ci.yml[1].github/workflows/dotnet-main.yml[2].github/workflows/dotnet-release.yml[3]SDK Version Upgrades:
AspireVersionfrom8.2.0to9.0.0-preview.4.24504.1inDirectory.Build.props. (Directory.Build.propsDirectory.Build.propsL10-R10)Aspire.AppHost.Sdkwith version9.0.0-preview.4.24477.2to various project files. (examples/java/Aspire.CommunityToolkit.Hosting.Java.AppHost/Aspire.CommunityToolkit.Hosting.Java.AppHost.csproj[1]examples/nodejs-ext/Aspire.CommunityToolkit.Hosting.NodeJS.Extensions.AppHost/Aspire.CommunityToolkit.Hosting.NodeJS.Extensions.AppHost.csproj[2]examples/ollama/Aspire.CommunityToolkit.Hosting.Ollama.AppHost/Aspire.CommunityToolkit.Hosting.Ollama.AppHost.csproj[3]examples/swa/Aspire.CommunityToolkit.StaticWebApps.AppHost/Aspire.CommunityToolkit.StaticWebApps.AppHost.csproj[4]Configuration Additions:
nuget.configfile with specific package sources and mappings for Aspire packages. (nuget.confignuget.configR1-R15)Test File Updates:
using Aspire.Hosting;to several test files to ensure proper namespace usage. (tests/Aspire.CommunityToolkit.Hosting.Java.Tests/ContainerResourceCreationTests.cs[1]tests/Aspire.CommunityToolkit.Hosting.Java.Tests/ExecutableResourceCreationTests.cs[2]tests/Aspire.CommunityToolkit.Hosting.NodeJS.Extensions.Tests/ResourceCreationTests.cs[3]PR Checklist
Other information