Skip to content

Data API Builder Integration #55

Closed
fboucher wants to merge 88 commits intomainfrom
39-data-api-builder-dab
Closed

Data API Builder Integration #55
fboucher wants to merge 88 commits intomainfrom
39-data-api-builder-dab

Conversation

@fboucher
Copy link
Copy Markdown
Contributor

@fboucher fboucher commented Oct 2, 2024

Closes #<ISSUE_NUMBER>

PR Checklist

  • Created a feature/dev branch in your fork (vs. submitting directly from a commit on main)
  • Based off latest main branch of toolkit
  • PR doesn't include merge commits (always rebase on top of our main, if needed)
  • New integration
    • Docs are written
    • Added description of major feature to project description for NuGet package (4000 total character limit, so don't push entire description over that)
  • Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Contains NO breaking changes
  • Every new API (including internal ones) has full XML docs
  • Code follows all style conventions

Other information

fboucher and others added 30 commits September 25, 2024 14:06
Improves container image annotation for dab.
Adds database_create sql script and adapts dab-config
@aaronpowell aaronpowell added the integration A new .NET Aspire integration label Oct 7, 2024
@aaronpowell
Copy link
Copy Markdown
Member

I can't get this running locally, DAB doesn't seem to be able to connect to the SQL container, regardless of whether it's running or not.

How are you running it, using the devcontainer or on bare metal?

@tommasodotNET
Copy link
Copy Markdown
Contributor

tommasodotNET commented Oct 9, 2024

I can't get this running locally, DAB doesn't seem to be able to connect to the SQL container, regardless of whether it's running or not.

How are you running it, using the devcontainer or on bare metal?

I'm running it on bare metal. Both on windows and wsl...

@aaronpowell
Copy link
Copy Markdown
Member

I can't get this running locally, DAB doesn't seem to be able to connect to the SQL container, regardless of whether it's running or not.

How are you running it, using the devcontainer or on bare metal?

I'm running it on bare metal. Both on windows and wsl...

I see. I only use the dev container and I wonder if that's having a networking problem which is also manifesting in how GitHub Actions runs (since it's a container and we run containers in it).

@aaronpowell aaronpowell added this to the aspire-9 milestone Oct 10, 2024
@aaronpowell aaronpowell mentioned this pull request Oct 10, 2024
10 tasks
@tommasodotNET
Copy link
Copy Markdown
Contributor

I can't get this running locally, DAB doesn't seem to be able to connect to the SQL container, regardless of whether it's running or not.
How are you running it, using the devcontainer or on bare metal?

I'm running it on bare metal. Both on windows and wsl...

I see. I only use the dev container and I wonder if that's having a networking problem which is also manifesting in how GitHub Actions runs (since it's a container and we run containers in it).

Yes, this a known network issue that should be solve in aspire 9
microsoft/aspire#5584

@aaronpowell aaronpowell mentioned this pull request Oct 16, 2024
10 tasks
@aaronpowell
Copy link
Copy Markdown
Member

Closing to replace with #98 that has been sync'ed with aspire-9 work

@aaronpowell aaronpowell deleted the 39-data-api-builder-dab branch October 16, 2024 04:12
andrey-noskov added a commit to andrey-noskov/Aspire-CommunityToolkit that referenced this pull request Apr 9, 2026
…kit#55)

Replace helm --wait with an IHealthCheck that polls the Kubernetes API
directly using the C# Kubernetes client. This surfaces real-time workload
readiness in the Aspire dashboard instead of blocking on Helm.

Changes:
- Add KubernetesWorkloadHealthCheck (IHealthCheck polling K8s API)
- Add KubernetesWorkloadStatusClient (queries Deployments/StatefulSets)
- Add KubernetesObjectStatus/KubernetesWorkloadStatus model records
- Add WorkloadReadiness with per-kind readiness evaluation
- Remove --wait from helm install arguments in HelmManager
- Wait for parent Kind cluster before starting helm install
- Show 'Waiting' state while cluster initializes
- Add KubernetesClient 19.0.2 dependency
- Add 63 unit tests covering readiness logic and status projection

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
(cherry picked from commit 03a9eccc4e861ce6c9627612de3a9639df747d8c)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integration A new .NET Aspire integration

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Data Api Builder (DAB)

5 participants