Skip to content

Data API Builder Integration#98

Merged
fboucher merged 67 commits intoaspire-9from
dab-aspire-9
Oct 16, 2024
Merged

Data API Builder Integration#98
fboucher merged 67 commits intoaspire-9from
dab-aspire-9

Conversation

@aaronpowell
Copy link
Copy Markdown
Member

@aaronpowell aaronpowell commented Oct 16, 2024

Closes #39

Note: This PR replaces #55 as it has been rebased on the Aspire 9 branch.

PR Checklist

  • Created a feature/dev branch in your fork (vs. submitting directly from a commit on main)
  • Based off latest main branch of toolkit
  • PR doesn't include merge commits (always rebase on top of our main, if needed)
  • New integration
    • Docs are written
    • Added description of major feature to project description for NuGet package (4000 total character limit, so don't push entire description over that)
  • Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Contains NO breaking changes
  • Every new API (including internal ones) has full XML docs
  • Code follows all style conventions

Other information

fboucher and others added 30 commits October 16, 2024 01:49
@fboucher @aaronpowell
draft
26b372a
@fboucher @aaronpowell
update namespace
94db7e0
@fboucher @aaronpowell
adding dab to solution
21f4b01
@tommasodotNET @aaronpowell
fixes the data api builder container creation
0f7426c
@tommasodotNET @aaronpowell
adds exaple for data api builder
e9c3250
@fboucher @aaronpowell
fixing nullable
96b5e62
@fboucher @aaronpowell
adding test and fixing namespace
9609bc4
@tommasodotNET @aaronpowell
improves container image annotation for dab
a02c9a2
@fboucher @aaronpowell
fixing last failing test
fc7f1bb
@fboucher @aaronpowell
simple cleaning
f947d0d
@tommasodotNET @aaronpowell
adds new way to configure dab only with name and config file
96b7c3b
@tommasodotNET @aaronpowell
improves dab creation by passing in parameter instead of DataAPIBuild…
8abef78 
…erContainerResourceOptions
@tommasodotNET @aaronpowell
fixes ambiguous method invocation
6b958b6
@tommasodotNET @aaronpowell
fixes ambiguous method invocation
05d0d06
@tommasodotNET @aaronpowell
improves AddDataAPIBuilder signature consistency
45f1333
@tommasodotNET @aaronpowell
initiliaze example with db integration
1480514
@tommasodotNET @aaronpowell
adds database_create sql script and adapts dab-config
8662a60
@fboucher @aaronpowell
fix start
cd9fb87
@fboucher @aaronpowell
adding comments
695fb45
@fboucher @aaronpowell
add Blazor - not ref yet
4d572e0
@fboucher @aaronpowell
fix graphql
3c7023b
@fboucher @aaronpowell
functional very basic demo
d4a0eda
@tommasodotNET @aaronpowell
adds doc
7d7c9b9
@tommasodotNET @aaronpowell
using only named parameters
5c6bf04
@tommasodotNET @aaronpowell
using default namespaces for consistency
2307d3f
@tommasodotNET @aaronpowell
fixes test to match new dab container config
2df1839
@tommasodotNET @aaronpowell
improves parameters check in AddDataAPIBuilder
a8e0520
@tommasodotNET @aaronpowell
adds tests for parameter check
08b8b5e
@tommasodotNET @aaronpowell
adds tests for dab apphost
b988202
@fboucher @aaronpowell
file is at a new location
ce81d52
@aaronpowell aaronpowell added the integration A new .NET Aspire integration label Oct 16, 2024
@aaronpowell aaronpowell added this to the aspire-9 milestone Oct 16, 2024
@aaronpowell aaronpowell mentioned this pull request Oct 16, 2024
Closed
10 tasks
tommasodotNET
tommasodotNET approved these changes Oct 16, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@tommasodotNET tommasodotNET left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@fboucher fboucher merged commit 10f2252 into aspire-9 Oct 16, 2024
@ErikEJ
Copy link
Copy Markdown
Contributor

ErikEJ commented Oct 21, 2024

@fboucher @aaronpowell Will this be published to the Azure DevOps packages feed? Would love to try it out

@aaronpowell aaronpowell deleted the dab-aspire-9 branch October 21, 2024 07:38
@aaronpowell
Copy link
Copy Markdown
Member Author

aaronpowell commented Oct 21, 2024

@fboucher @aaronpowell Will this be published to the Azure DevOps packages feed? Would love to try it out

Yep, just got to update the aspire-9 branch (it has some merge conflicts) and that will trigger a new build that will end up in the PR feed.

I'll get to that tomorrow morning unless someone can jump in first

@tommasodotNET
Copy link
Copy Markdown
Contributor

tommasodotNET commented Oct 21, 2024

Sorry @aaronpowell I have to leave it to you cause I this week is full of conferences and hackathon for me :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ErikEJ ErikEJ ErikEJ left review comments

@tommasodotNET tommasodotNET tommasodotNET approved these changes

Assignees

@fboucher fboucher

Labels

integration A new .NET Aspire integration

Projects

None yet

Milestone

aspire-9

Development

Successfully merging this pull request may close these issues.

5 participants

@aaronpowell @ErikEJ @tommasodotNET @fboucher @Alirexaa