chore: Removes DeprecatedLoading, DeprecatedModal and Checkbox#672
Merged
frankieyan merged 1 commit intomainfrom Aug 15, 2022
Merged
chore: Removes DeprecatedLoading, DeprecatedModal and Checkbox#672frankieyan merged 1 commit intomainfrom
frankieyan merged 1 commit intomainfrom
Conversation
jvalente
approved these changes
Jul 12, 2022
6 tasks
ea1900f to
92639c4
Compare
Closed
92639c4 to
1b9f12b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short description
These 3 components are no longer used in either Todoist or Twist, so I'm taking the opportunity that we'll have a breaking change release soon (see #671) to remove them entirely.
Test plan
Double-check that Todoist and Twist codebase do not use any of these components.
For the two with the word "deprecated" in their names, it is straightforward.
For
Checkboxis trickier, but make sure to search in the entire codebase that name with case-sensitive search and the exact word. Then exclude the test files, cypress, i18n files, to get less false positives. You should be left with a relatively small number of hits that you can then validate are non from importing from Reactist.PR Checklist
npm run validateand made sure no errors / warnings were shownCHANGELOG.mdpackage.jsonandpackage-lock.json(npm --no-git-tag-version version <major|minor|patch>) refnpm run build-all)Versioning
New major release.