chore: Deprecate Dropdown, Input, Select; Remove Popover#680
Merged
frankieyan merged 7 commits intomainfrom Aug 15, 2022
Merged
chore: Deprecate Dropdown, Input, Select; Remove Popover#680frankieyan merged 7 commits intomainfrom
frankieyan merged 7 commits intomainfrom
Conversation
frankieyan
requested review from
a team and
nats12
and removed request for
a team
frankieyan
changed the title
Member
Author
|
On hold as this overlaps some of the work from #672 |
frankieyan
force-pushed
the
frankie/deprecate-components
branch
from
0be5dbd to
88a953b
Compare
frankieyan
changed the title
frankieyan
changed the base branch from
main
to
ernesto/remove-deprecated-components
frankieyan
requested review from
a team,
gnapse and
pedroalves0
and removed request for
a team and
pedroalves0
Closed
frankieyan
force-pushed
the
ernesto/remove-deprecated-components
branch
from
92639c4 to
1b9f12b
Compare
gnapse
approved these changes
Aug 15, 2022
| @@ -41,8 +41,8 @@ type Props = { | |||
|
|
|||
| function ColorPicker({ color = 0, small, onChange, colorList = COLORS }: Props) { | |||
Contributor
There was a problem hiding this comment.
I wonder if we should deprecate this one, given that:
- It is relying on a deprecated component (technically not a reason for deprecating it, as it should be re-implemented internally to use something else)
- More importantly: I think we should create a new one eventually that will probably have a different interface), and I'd also rename the new one to be a "select" and not a "picker".
Anyway, maybe not do anything about it now. I'm just dumping my thoughts.
Co-authored-by: Ernesto García <ernesto@doist.com>
frankieyan
force-pushed
the
frankie/deprecate-components
branch
from
680f520 to
6ecfbaa
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short description
As titled, this removes a couple components that have been deprecated for a while as we no longer use them in Todoist or Twist, and deprecates a few more components that will be removed in the future.
This allows us to reduce the scope of #676 so we have fewer legacy tests to maintain.
Deprecations
Dropdown: still used in Twist and its export has been renamed toDeprecatedDropdownInput: still used in Twist and its export has been renamed toDeprecatedInput.TextFieldshould be used insteadSelect: one instance in Twist and one in Todoist.SelectFieldshould be used instead, renamed and will be removed in the next releaseRemovals
Popover: this was undocumented and wasn't used in our codebasesTwist discussion around replacements for
Dropdown: https://twist.com/a/1585/ch/190200/t/3685978/PR Checklist
npm run validateand made sure no errors / warnings were shownCHANGELOG.mdpackage.jsonandpackage-lock.json(npm --no-git-tag-version version <major|minor|patch>) refnpm run build-all)Versioning
Major