Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,11 @@ Reactist follows [semantic versioning](https://semver.org/) and doesn't introduc
- [Breaking] Button's `tooltipGapSize` prop is no longer supported. When wanting to customize the tooltip appearance, consumers should take ownership of rendering the tooltip manually.
- [Breaking] Icon-only buttons can have their implicit "aria-label as tooltip" behaviour suppressed by passing `tooltip={null}`. Useful when wanting to get full control over rendering the tooltip manually.
- [Breaking] Remove deprecated components `Checkbox`, `DeprecatedLoading` and `DeprecatedModal`.
- [Breaking] Remove `Popover`
- [Breaking] The following components have been renamed and will be removed in a future major release:
- `Dropdown` -> `DeprecatedDropdown`
- `Input` -> `DeprecatedInput`, use `TextField` instead.
- `Select` -> `DeprecatedSelect`, use `SelectField` instead.

# v12.1.1

Expand Down
14 changes: 7 additions & 7 deletions src/components/color-picker/color-picker.tsx
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import React from 'react'
import classnames from 'classnames'

import Dropdown from '../dropdown'
import DeprecatedDropdown from '../deprecated-dropdown'
import { Tooltip } from '../tooltip'

import './color-picker.less'
Expand Down Expand Up @@ -41,8 +41,8 @@ type Props = {

function ColorPicker({ color = 0, small, onChange, colorList = COLORS }: Props) {
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we should deprecate this one, given that:

  • It is relying on a deprecated component (technically not a reason for deprecating it, as it should be re-implemented internally to use something else)
  • More importantly: I think we should create a new one eventually that will probably have a different interface), and I'd also rename the new one to be a "select" and not a "picker".

Anyway, maybe not do anything about it now. I'm just dumping my thoughts.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logged under #682 👍

return (
<Dropdown.Box right className="reactist_color_picker">
<Dropdown.Trigger>
<DeprecatedDropdown.Box right className="reactist_color_picker">
<DeprecatedDropdown.Trigger>
{(() => {
const backgroundColor = _getColor(colorList, color)

Expand All @@ -59,8 +59,8 @@ function ColorPicker({ color = 0, small, onChange, colorList = COLORS }: Props)
</span>
)
})()}
</Dropdown.Trigger>
<Dropdown.Body>
</DeprecatedDropdown.Trigger>
<DeprecatedDropdown.Body>
<div className="color_options">
{colorList.reduce<React.ReactNode[]>((items, currentColor, currentIndex) => {
items.push(
Expand All @@ -82,8 +82,8 @@ function ColorPicker({ color = 0, small, onChange, colorList = COLORS }: Props)
return items
}, [])}
</div>
</Dropdown.Body>
</Dropdown.Box>
</DeprecatedDropdown.Body>
</DeprecatedDropdown.Box>
)
}
ColorPicker.displayName = 'ColorPicker'
Expand Down
File renamed without changes.
68 changes: 0 additions & 68 deletions src/components/popover/__snapshots__/popover.test.tsx.snap

This file was deleted.

3 changes: 0 additions & 3 deletions src/components/popover/index.ts

This file was deleted.

116 changes: 0 additions & 116 deletions src/components/popover/popover.less

This file was deleted.

Loading