Skip to content

fix(windows): make remaining paths use rlocation#361

Merged
alexeagle merged 1 commit intoGoogleContainerTools:mainfrom
aspect-forks:main
Jul 28, 2023
Merged

fix(windows): make remaining paths use rlocation#361
alexeagle merged 1 commit intoGoogleContainerTools:mainfrom
aspect-forks:main

Conversation

@alexeagle
Copy link
Copy Markdown
Collaborator

I think this is the last missing code change to get rules_oci bcr test green on Windows.

Note, we'll still need a release of the binaries in this repo, and then another change to mirror those into repositories.bzl.

@alexeagle alexeagle requested a review from thesayyn July 27, 2023 23:04
@alexeagle alexeagle merged commit 4ae1f90 into GoogleContainerTools:main Jul 28, 2023
@timonwong
Copy link
Copy Markdown

@alexeagle It seems this PR reverts the work in #347? After upgrading I hit error like this:

Error: error creating driver: processing tar image reference: mkdir /var/folders/nh/494h__wn4rq_wr68cr5qn9sh0000gn/T/privatevartmp_bazel_timonwongf8e522ad4eb28d0876e69e8716848e79execrootio_alauda_asm_asmbazel-outdarwin_arm64-optbincmdglobal-asm-controllerimage-test.linux_amd64.sh.runfilesio_alauda_asm_asmcmdglobal-asm-controllerimage.tar.linux_amd64tarball.tar@sha256:fac37afd164231cb790e21192377d9ae6120fa1e2b96108be747a83b060d0586517621879: file name too long

@alexeagle
Copy link
Copy Markdown
Collaborator Author

@timonwong that error was fixed in GoogleContainerTools/container-diff#395 (comment)

and brought to this repo in 8b6e083

@timonwong
Copy link
Copy Markdown

timonwong commented Sep 28, 2023

@alexeagle I don't know why it's stopped working, previously I'm using your fork, after I changed cst to v1.16.0 it shows "file name too long error" again:

EDIT It seems my environment problem, I'm looking into it

    container_structure_test = dict(
        sha256 = "2da13da4c4fec9d4627d4084b122be0f4d118bd02dfa52857ff118fde88e4faa",
        version = "1.16.0",
        strip_prefix = "container-structure-test-{version}",
        urls = [
            "https://github.com/GoogleContainerTools/container-structure-test/archive/v{version}.zip",
        ],
    ),

Previously:

    container_structure_test = dict(
        sha256 = "6913d8b5fa701b07d30ca236d2ab9e456ea0da415266cd8910a4537fb9222445",
        version = "e5848342114f9a435e9a54f45bef99a7703c9173",
        strip_prefix = "container-structure-test-{version}",
        urls = [
            "https://github.com/GoogleContainerTools/container-structure-test/archive/{version}.zip",
        ],
    ),

@timonwong
Copy link
Copy Markdown

@alexeagle Ooops, finally figured out it's because the v1.16.0 tag on 8113400 does not contains actual binaries in 18d9b2b

I have to update my bazel repository accordingly:

    container_structure_test = dict(
        sha256 = "620a7223a0f10434b12c34271bc0086655375c2dca024fc372bd9f1838e5307b",
        version = "aa025d1c83d95a27a367d4e5df9bb1dc67c1f3e8",
        strip_prefix = "container-structure-test-{version}",
        urls = [
            "https://github.com/GoogleContainerTools/container-structure-test/archive/{version}.zip",
        ],
    ),

@alexeagle
Copy link
Copy Markdown
Collaborator Author

Err yeah... sorry! We have a fix for that now so the next release won't have that problem

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants