fix(windows): make remaining paths use rlocation#361
Merged
alexeagle merged 1 commit intoGoogleContainerTools:mainfrom Jul 28, 2023
Merged
fix(windows): make remaining paths use rlocation#361alexeagle merged 1 commit intoGoogleContainerTools:mainfrom
alexeagle merged 1 commit intoGoogleContainerTools:mainfrom
Conversation
thesayyn
approved these changes
Jul 27, 2023
|
@alexeagle It seems this PR reverts the work in #347? After upgrading I hit error like this: |
Collaborator
Author
|
@timonwong that error was fixed in GoogleContainerTools/container-diff#395 (comment) and brought to this repo in 8b6e083 |
|
@alexeagle I don't know why it's stopped working, previously I'm using your fork, after I changed cst to v1.16.0 it shows "file name too long error" again: EDIT It seems my environment problem, I'm looking into it Previously: |
|
@alexeagle Ooops, finally figured out it's because the v1.16.0 tag on 8113400 does not contains actual binaries in 18d9b2b I have to update my bazel repository accordingly: |
Collaborator
Author
|
Err yeah... sorry! We have a fix for that now so the next release won't have that problem |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think this is the last missing code change to get rules_oci bcr test green on Windows.
Note, we'll still need a release of the binaries in this repo, and then another change to mirror those into repositories.bzl.