Upgrade React Native to 0.71.6

[jpcloureiro]

Description

React Native upgrade to 0.71.6 requires

Upgrade Helper

By using React-native upgrade helper (https://react-native-community.github.io/upgrade-helper/) we were able to bump one major version at a time. This approach allows us to handle specific version bump issues separately.

Most of the native (ios, android) changes were grabbed from this helper

React native Reanimated

Using Reanimated 2 we have the option to use Reanimated API v1 or V2. https://docs.swmansion.com/react-native-reanimated/docs/2.x/fundamentals/migration

Reanimated team added support for RN 0.71 on 2.14.4 but it is crashing our app on iOS native side.

We are forced to use Reanimated 3. This version only ships API v2, forcing us to do the V1 -> V2 migration as well as the gesture-handler that depends on it.

Hermes engine on Android

JSC does not fully support BigInt operations & that is a requirement for our app.

hermes version that comes with 0.71.6 crashes when some specific errors are thrown.

We can't use the latest version of hermes on 0.71.6 because its API is not compatible.

commit that fixes the crash facebook/hermes@f2f1a2e
We checked out https://github.com/facebook/hermes/releases/tag/hermes-2023-03-07-RNv0.71.4-31fdcf738940875c9bacf251e149006cf515d763, and cherry-picked the fix.

here's the tarball we are using https://github.com/MetaMask/hermes/tree/ae2ac688c3faf868d2360a10a7791226ed5702fb

hermes-engine/build.gradle had to be patched to allow the build process to fetch the tarball from our fork.

Why not Hermes on iOS as well?

We use JSC on iOS because it already has the necessary BigInt support. We tested hermes on iOS & it was unstable on our project (crashes)

Issue

Progresses https://github.com/metamask/mobile-planning/issues/690

Checklist

• There is a related GitHub issue
• Tests are included if applicable
• Any added code is fully documented

[jpcloureiro]

Our unit tests are failing on the components AdvancedSettings & EthSignFriction

EthSignFriction

It can't find the element with the role "button"

AdvancedSettings

We seem to have issues with the navigation mock.

There are also two snapshots that need to be updated.

[cortisiko]

This PR is officially QA passed.

[jpcloureiro]

This version bump happened when we had to regenerate yarn.lock

Hmm, why was this required? Regenerating the lockfile is a big change. If we could avoid this, we could reduce scope of this PR substantially and delay resolving the hexToBN issue described

Hey @Gudahtt we've revised yarn.lock to keep its changes to a minimum by running yarn on top of a yarn.lock file from main.

We also removed the hexToBN auxiliary function, leaving it as it was before.

Thanks for pointing that out!

[leotm]

great pairing and reviewing this pr today, lgtm

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

3 Bugs
0 Vulnerabilities
0 Security Hotspots
5 Code Smells

13.5% Coverage
0.0% Duplication