RN upgrade: yarn.lock from main#6690
Closed
jpcloureiro wants to merge 14 commits intoupgrade/react-native/0.71.6-hermesfrom
Closed
RN upgrade: yarn.lock from main#6690jpcloureiro wants to merge 14 commits intoupgrade/react-native/0.71.6-hermesfrom
jpcloureiro wants to merge 14 commits intoupgrade/react-native/0.71.6-hermesfrom
Conversation
Packages used solely for development tools and testing have been moved from `dependencies` to `devDependencies`.
* feat: trigger qrsigning modal using approval controller * fix: use approval request to control QR modal * remove QRState usage * use approval request to control QR modal for tx * fix lint * add early return on qr signing modal --------- Co-authored-by: Vinicius Stevam <vinicius.stevam@consensys.net> Co-authored-by: Vinicius Stevam <45455812+vinistevam@users.noreply.github.com>
Co-authored-by: SamuelSalas <samuel.salas.reyes@gmail.com>
* fix(action): add required permissions to remove labels * fix(action name): adopt kebab case
The Yarn audit failure has been addressed by ignoring the flagged security advisory. It is a ReDoS advisory, which doesn't present a risk for us (it's not used for a server, so there is no way for an attacker to impact our availability). The audit file has been slightly reorganized to remove an obsolete comment, and to place the explanations above each entry rather than below.
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
|
New and updated dependencies detected. Learn more about Socket for GitHub ↗︎
|
jpcloureiro
force-pushed
the
rn-upgrade-new-yarnlock
branch
2 times, most recently
from
5b20128 to
0b8059c
Compare
|
SonarCloud Quality Gate failed.
|
jpcloureiro
force-pushed
the
rn-upgrade-new-yarnlock
branch
from
0b8059c to
d68ea4b
Compare
Contributor
Author
|
Testing complete. Code changes will be addressed directly on #6220 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Development & PR Process
release-xxlabel to identify the PR slated for a upcoming release (will be used in release discussion)needs-dev-reviewlabel when work is completedneeds-qalabel when dev review is completedQA Passedlabel when QA has signed offDescription
The goal is to maintain all functionalities with the minimal dependency changes.
yarn.lock change stats
on
upgrade/react-native/0.71.6-hermeson this branch
rn-upgrade-new-yarnlockOther changes
mainmerge brings newer file changeshexToBNcatchall function since we are on the same version ofethereumjs-utilas in mainScreenshots/Recordings
If applicable, add screenshots and/or recordings to visualize the before and after of your change
Issue
Progresses #???
Checklist