convert protocal names to be found as labels#3747
Merged
DaanHoogland merged 2 commits intoapache:4.13from Dec 20, 2019
Merged
Conversation
Contributor
Author
|
@blueorangutan package |
5 tasks
|
@DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. |
|
Packaging result: ✔centos6 ✔centos7 ✔debian. JID-430 |
yadvr
approved these changes
Dec 7, 2019
yadvr
reviewed
Dec 7, 2019
Contributor
|
@blueorangutan package |
|
@borisstoyanov a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. |
|
Packaging result: ✔centos6 ✔centos7 ✔debian. JID-471 |
borisstoyanov
approved these changes
Dec 16, 2019
Contributor
borisstoyanov
left a comment
borisstoyanov
left a comment
There was a problem hiding this comment.
LGTM, checked on mac with FF, Chrom and Safari.
DaanHoogland
added a commit
that referenced
this pull request
Dec 20, 2019
* create template from snapshot regression (partly reverted) (#3767) * Once again allow a VM to be on multiple networks from VPCs (#3754) to once again allow a VM to be on multiple networks from VPCs * convert protocal names to be found as labels (#3747) * convert protocal names to be found as labels * format * filter hosts to query on zone wide storage (#3733) * config: add isdynamic flag in configuration response (#3729) Co-authored-by: Wei Zhou <ustcweizhou@gmail.com>
DaanHoogland
added a commit
that referenced
this pull request
Dec 23, 2019
* 4.13: Added zone check for attach iso (#3755) config: add isdynamic flag in configuration response (#3729) filter hosts to query on zone wide storage (#3733) convert protocal names to be found as labels (#3747) Once again allow a VM to be on multiple networks from VPCs (#3754) create template from snapshot regression (partly reverted) (#3767)
ustcweizhou
pushed a commit
to ustcweizhou/cloudstack
that referenced
this pull request
Feb 28, 2020
* convert protocal names to be found as labels * format
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
replace significant chars from string to find protocol labels
Fixes: #3252
Types of changes
Screenshots (if appropriate):
How Has This Been Tested?