create template from snapshot regression (partly reverted)#3767
create template from snapshot regression (partly reverted)#3767DaanHoogland merged 1 commit intoapache:4.13from
Conversation
|
@blueorangutan package |
|
@borisstoyanov a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. |
|
Packaging result: ✖centos6 ✔centos7 ✔debian. JID-465 |
|
@DaanHoogland If I understood it correctly, this PR should go to 4.13.1.0. If so, can you please change the target branch to 4.13? |
|
Have I missed something here? Where did take snapshot button go? |
|
tnx @GabrielBrascher |
|
@blueorangutan package |
|
@borisstoyanov a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. |
|
Packaging result: ✔centos6 ✔centos7 ✔debian. JID-470 |
|
I double checked the changes in this PR @borisstoyanov . These exact changes are in master so if the bug is not on master there is something else wrong either in 4.13 or inyour env. I'm testing in simulator as well. |
borisstoyanov
left a comment
borisstoyanov
left a comment
There was a problem hiding this comment.
UI displays job is in progress, but actually the template is ready. It's been like that for more than 10 min.
borisstoyanov
left a comment
borisstoyanov
left a comment
There was a problem hiding this comment.
LGTM. missing snapshot button was related to a change in KVM when VM in running state the button is hidden, and for the UI I've created a separate issue.
GabrielBrascher
left a comment
GabrielBrascher
left a comment
There was a problem hiding this comment.
Thanks for the PR @DaanHoogland.
Code LGTM. Additionally, it has been approved already for master and tested.
* create template from snapshot regression (partly reverted) (#3767) * Once again allow a VM to be on multiple networks from VPCs (#3754) to once again allow a VM to be on multiple networks from VPCs * convert protocal names to be found as labels (#3747) * convert protocal names to be found as labels * format * filter hosts to query on zone wide storage (#3733) * config: add isdynamic flag in configuration response (#3729) Co-authored-by: Wei Zhou <ustcweizhou@gmail.com>
* 4.13: Added zone check for attach iso (#3755) config: add isdynamic flag in configuration response (#3729) filter hosts to query on zone wide storage (#3733) convert protocal names to be found as labels (#3747) Once again allow a VM to be on multiple networks from VPCs (#3754) create template from snapshot regression (partly reverted) (#3767)
4 participants
Description
see #3723 for details. backport after merging
Types of changes
Screenshots (if appropriate):
How Has This Been Tested?