a conditional to prevent creation of a field#3723
Merged
DaanHoogland merged 1 commit intoapache:masterfrom Nov 29, 2019
Merged
Conversation
Contributor
|
@blueorangutan package |
|
@andrijapanicsb a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. |
|
Packaging result: ✖centos6 ✔centos7 ✔debian. JID-401 |
Contributor
Author
|
Not sure why i thought this would work, maybe a copy error in my dev env. |
DaanHoogland
force-pushed
the
templateFromSnapshot
branch
from
cb92ab8 to
1153e3e
Compare
Contributor
Author
|
@blueorangutan package |
|
@DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. |
|
Packaging result: ✖centos6 ✔centos7 ✔debian. JID-403 |
andrijapanicsb
approved these changes
Nov 28, 2019
Contributor
andrijapanicsb
left a comment
andrijapanicsb
left a comment
There was a problem hiding this comment.
LGTM
Tested manually.
Contributor
Author
|
@GabrielBrascher @andrijapanicsb should we backport this to 4.13? It seems like a genuine regression to me. |
Contributor
|
+1 |
Contributor
Author
|
ok, as this is already merged, i'll create a new PR |
5 tasks
ustcweizhou
pushed a commit
to ustcweizhou/cloudstack
that referenced
this pull request
Feb 28, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the files is based on volumes and will npe (if that's a thing in javascript)
when applied in the snapshot dialog
Description
Fixes: #3716
Types of changes
Screenshots (if appropriate):
How Has This Been Tested?
manually (see screenshot)