ui: fix merge issue that causes VR duplicates#3927
Merged
DaanHoogland merged 1 commit intoapache:masterfrom Mar 4, 2020
Merged
ui: fix merge issue that causes VR duplicates#3927DaanHoogland merged 1 commit intoapache:masterfrom
DaanHoogland merged 1 commit intoapache:masterfrom
Conversation
This fixes issue from merging 4d8a2da on master/4.14-snapshot which causes duplicate VRs to show up. Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
Member
Author
|
This is UI only change backend smoketests not necessary, manual test/confirmation is asked |
|
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. |
|
Packaging result: ✖centos6 ✔centos7 ✔debian. JID-993 |
DaanHoogland
approved these changes
Mar 4, 2020
Contributor
DaanHoogland
left a comment
DaanHoogland
left a comment
There was a problem hiding this comment.
code change good, testing of corner cases by every one invited
|
|
||
| $.ajax({ | ||
| url: createURL("listRouters&listAll=true&page=" + args.page + "&pagesize=" + pageSize + array1.join("") + "&projectid=-1"), | ||
| url: createURL("listRouters&page=" + args.page + "&pagesize=" + pageSize + array1.join("") + "&projectid=-1"), |
Contributor
There was a problem hiding this comment.
listall | If set to false, list only resources belonging to the command's caller; if set to true - list resources that the caller is authorized to see. Default value is false
so if the admin calls this and a router would not belong to them... I'll test some scenarios
weizhouapache
approved these changes
Mar 4, 2020
Member
weizhouapache
left a comment
weizhouapache
left a comment
There was a problem hiding this comment.
looks good.
tested with network/vpc in normal view, and isolated network in project view.
Member
Author
|
@DaanHoogland please merge once you've tested and are satisfied |
Contributor
|
tested with isolated vpc and shared as user and admin |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes issue from merging 4d8a2da
on master/4.14-snapshot which causes duplicate VRs to show up.
Fixes #3926
Types of changes