Skip to content

ui: fix merge issue that causes VR duplicates #3927

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DaanHoogland merged 1 commit into from
Mar 4, 2020
Merged

ui: fix merge issue that causes VR duplicates #3927

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ui/scripts/system.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9996,7 +9996,7 @@
}

$.ajax({
url: createURL("listRouters&listAll=true&page=" + args.page + "&pagesize=" + pageSize + array1.join("") + "&projectid=-1"),
url: createURL("listRouters&page=" + args.page + "&pagesize=" + pageSize + array1.join("") + "&projectid=-1"),
Copy link
Copy Markdown
Contributor

@DaanHoogland DaanHoogland Mar 4, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

listall | If  set to false, list only resources belonging to the command's caller; if  set to true - list resources that the caller is authorized to see.  Default value is false

so if the admin calls this and a router would not belong to them... I'll test some scenarios

data: data2,
async: false,
success: function (json) {
Expand Down