Skip to content
This repository was archived by the owner on Nov 17, 2023. It is now read-only.

[BUGFIX] Assure NDArray.reshape does not change the array size#19078

Merged
marcoabreu merged 1 commit intoapache:masterfrom
r3stl355:master
Sep 6, 2020
Merged

[BUGFIX] Assure NDArray.reshape does not change the array size#19078
marcoabreu merged 1 commit intoapache:masterfrom
r3stl355:master

Conversation

@r3stl355
Copy link
Copy Markdown
Contributor

@r3stl355 r3stl355 commented Sep 2, 2020

Description

Solves #18886

Checklist

Essentials

  • PR's title starts with a category (e.g. [BUGFIX], [MODEL], [TUTORIAL], [FEATURE], [DOC], etc)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage
  • Code is well-documented

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@r3stl355 r3stl355 requested a review from szha as a code owner September 2, 2020 21:38
@mxnet-bot
Copy link
Copy Markdown

mxnet-bot commented Sep 2, 2020

Hey @r3stl355 , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [windows-gpu, unix-cpu, miscellaneous, windows-cpu, unix-gpu, sanity, website, centos-gpu, centos-cpu, edge, clang]

Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

@r3stl355
Copy link
Copy Markdown
Contributor Author

r3stl355 commented Sep 3, 2020

@mxnet-bot run ci [unix-cpu,unix-gpu]

@mxnet-bot
Copy link
Copy Markdown

mxnet-bot commented Sep 3, 2020

Jenkins CI successfully triggered : [unix-gpu, unix-cpu]

@r3stl355
Copy link
Copy Markdown
Contributor Author

r3stl355 commented Sep 3, 2020

@mxnet-bot run ci [windows-gpu]

@mxnet-bot
Copy link
Copy Markdown

mxnet-bot commented Sep 3, 2020

Jenkins CI successfully triggered : [windows-gpu]

@r3stl355
Copy link
Copy Markdown
Contributor Author

r3stl355 commented Sep 5, 2020

Can anyone review this please so I can implement the same against 1.x branches? It looks like it now has some conflicts, should I resolve those locally and re-submit?

@szha
Copy link
Copy Markdown
Member

szha commented Sep 5, 2020

@r3stl355 we deprecated contrib text in master. could you rebase?

@r3stl355
Copy link
Copy Markdown
Contributor Author

r3stl355 commented Sep 5, 2020

Sure, will do

@r3stl355 r3stl355 force-pushed the master branch 2 times, most recently from 32b4ce1 to 3948930 Compare September 5, 2020 21:04
szha
szha approved these changes Sep 5, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@szha szha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for the fix!

@r3stl355
Copy link
Copy Markdown
Contributor Author

r3stl355 commented Sep 6, 2020

@mxnet-bot run ci [windows-gpu]

@mxnet-bot
Copy link
Copy Markdown

mxnet-bot commented Sep 6, 2020

Jenkins CI successfully triggered : [windows-gpu]

@marcoabreu marcoabreu merged commit 62b7f03 into apache:master Sep 6, 2020
@r3stl355 r3stl355 mentioned this pull request Sep 6, 2020
Merged
4 tasks
szha pushed a commit that referenced this pull request Sep 29, 2020
@r3stl355 @ulmasov
[1.x] Backport of #19078 (#19095)
16280ad 
* Assure NDArray.reshape does not change the array size

* Truncate wikitext-2 to match target array size on reshape

Co-authored-by: r3stl355 <ulmasov@amazon.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@aaronmarkham aaronmarkham Awaiting requested review from aaronmarkham

1 more reviewer

@szha szha szha approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@r3stl355 @mxnet-bot @szha @marcoabreu @ulmasov