Skip to content
This repository was archived by the owner on Nov 17, 2023. It is now read-only.

[1.x] Backport of #19078#19095

Merged
szha merged 2 commits intoapache:v1.xfrom
r3stl355:v1.x
Sep 29, 2020
Merged

[1.x] Backport of #19078#19095
szha merged 2 commits intoapache:v1.xfrom
r3stl355:v1.x

Conversation

@r3stl355
Copy link
Copy Markdown
Contributor

@r3stl355 r3stl355 commented Sep 6, 2020

Description

Backport of #19078 to v1.x (solves #18886)

Checklist

Essentials

  • PR's title starts with a category (e.g. [BUGFIX], [MODEL], [TUTORIAL], [FEATURE], [DOC], etc)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage
  • Code is well-documented

@r3stl355 r3stl355 requested a review from szha as a code owner September 6, 2020 21:25
@mxnet-bot
Copy link
Copy Markdown

Hey @r3stl355 , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [windows-gpu, unix-gpu, miscellaneous, centos-cpu, windows-cpu, edge, unix-cpu, sanity, centos-gpu, clang, website]


Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

@szha
Copy link
Copy Markdown
Member

szha commented Sep 6, 2020

@r3stl355 thanks for backporting! remember to add back the part for text processing as it's still available in contrib on 1.x

@r3stl355
Copy link
Copy Markdown
Contributor Author

r3stl355 commented Sep 7, 2020

@szha thanks, yes, I realised that at some point after submitting the PR. I still need to figure out how to run all the tests locally, doing nosetests tests/python/unittest/ segfaults and crashes Python on my Mac

@szha
Copy link
Copy Markdown
Member

szha commented Sep 7, 2020

@szha thanks, yes, I realised that at some point after submitting the PR. I still need to figure out how to run all the tests locally, doing nosetests tests/python/unittest/ segfaults and crashes Python on my Mac

This seems to be a common request. I recently shared some of it in #18997 (comment), though I think we likely need to expand a bit more and add in https://github.com/apache/incubator-mxnet/blob/master/docs/static_site/src/pages/community/code_guide.md#testing

@r3stl355
Copy link
Copy Markdown
Contributor Author

r3stl355 commented Sep 7, 2020

Great, I'll try to make it run on my machine and update the docs

@r3stl355
Copy link
Copy Markdown
Contributor Author

r3stl355 commented Sep 9, 2020

@szha - do you want to merge this before the 1.8 release?

@leezu
Copy link
Copy Markdown
Contributor

leezu commented Sep 9, 2020

You can suggest the inclusion in #18800

@szha szha merged commit 16280ad into apache:v1.x Sep 29, 2020
@r3stl355 r3stl355 deleted the v1.x branch October 9, 2020 21:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants