This repository was archived by the owner on Nov 17, 2023. It is now read-only.
[BUGFIX] [1.x] Backport of "Avoid logging seed for skipped tests #19322"#19327
Closed
DickJC123 wants to merge 1 commit intoapache:v1.xfrom
Closed
[BUGFIX] [1.x] Backport of "Avoid logging seed for skipped tests #19322"#19327DickJC123 wants to merge 1 commit intoapache:v1.xfrom
DickJC123 wants to merge 1 commit intoapache:v1.xfrom
Conversation
|
Hey @DickJC123 , Thanks for submitting the PR
CI supported jobs: [windows-gpu, sanity, clang, miscellaneous, windows-cpu, website, centos-cpu, centos-gpu, edge, unix-gpu, unix-cpu] Note: |
6 tasks
Contributor
Author
|
I can verify the PR has fixed the problem. In the centos-cpu log of this PR: while in a log from an early 1.x PR #19296 without this fix: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This fixes issue #19255, where it was noted that when a unittest was skipped, the skip-exception caused the with_seed() decorator to log the seed. While the 1.x branch uses nosetests, not pytest, the same behavior is seen on 1.x. With this PR the seed is no longer logged.
This PR doesn't have any testing added- I will inspect the CI log for skipped tests such as test_operator.py:test_activation to verify that the seed logging has been successfully eliminated.
@leezu @samskalicky
Checklist
Essentials