Skip to content
This repository was archived by the owner on Nov 17, 2023. It is now read-only.

[BUGFIX] [1.8.x] Backport of "Avoid logging seed for skipped tests #19322"#19328

Closed
DickJC123 wants to merge 1 commit intoapache:v1.8.xfrom
DickJC123:with_seed_skip_fix_v1.8.x
Closed

[BUGFIX] [1.8.x] Backport of "Avoid logging seed for skipped tests #19322"#19328
DickJC123 wants to merge 1 commit intoapache:v1.8.xfrom
DickJC123:with_seed_skip_fix_v1.8.x

Conversation

@DickJC123
Copy link
Copy Markdown
Contributor

Description

This fixes issue #19255, where it was noted that when a unittest was skipped, the skip-exception caused the with_seed() decorator to log the seed. While the 1.8.x branch uses nosetests, not pytest, the same behavior is seen on 1.8..x. With this PR the seed is no longer logged.

This PR doesn't have any testing added- I will inspect the CI log for skipped tests such as test_operator.py:test_activation to verify that the seed logging has been successfully eliminated.

This is identical to the master -> 1.x backport PR #19327.

@leezu @samskalicky

Checklist

Essentials

  • PR's title starts with a category (e.g. [BUGFIX], [MODEL], [TUTORIAL], [FEATURE], [DOC], etc)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage
  • Code is well-documented

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@mxnet-bot
Copy link
Copy Markdown

Hey @DickJC123 , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [unix-gpu, windows-gpu, website, miscellaneous, centos-gpu, unix-cpu, sanity, centos-cpu, windows-cpu, edge, clang]


Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

@DickJC123
Copy link
Copy Markdown
Contributor Author

I can verify the PR works on 1.8.x, similar to my comments for the identical 1.x PR: #19327 (comment)

@lanking520 lanking520 added pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Oct 29, 2020
@DickJC123 DickJC123 closed this Mar 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

pr-work-in-progress PR is still work in progress

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants