refactor: refactor envbuilder to use coder/serpent as CLI engine#140
refactor: refactor envbuilder to use coder/serpent as CLI engine#140BrunoQuaresma merged 22 commits intomainfrom
Conversation
johnstcn
left a comment
There was a problem hiding this comment.
It probably makes sense to use coder/serpent here as what I'm seeing is essentially a reimplementation of a subset of its existing functionality.
mtojek
left a comment
There was a problem hiding this comment.
I believe you are heading in the right direction. Most of my comments pertain to adhering to the Go convention, but the overall concept is correct.
I suggest narrowing the scope of this PR to solely adopting coder/serpent (what you have now) and then preparing a follow-up to implement clidocgen. What do you think?
Marcin is going to be on PTO next week
|
@mafredri @johnstcn @dannykopping I think this PR is in a good state to get merged. Here are some followups from the reviews:
I'm planning to create an issue + PR for each one of them after merging #147. |
Related to #130