fix: stronger and more explicit linter options#267
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #267 +/- ##
==========================================
+ Coverage 55.16% 55.18% +0.01%
==========================================
Files 48 48
Lines 8802 8800 -2
==========================================
Hits 4856 4856
+ Misses 3193 3191 -2
Partials 753 753
Continue to review full report at Codecov.
|
Contributor
|
Is this ready for review? |
Contributor
Author
|
No. I wanted to actually fix all the newly exposed linter issues in this PR. |
97650fa to
4b78bef
Compare
adlerjohn
approved these changes
Jul 7, 2022
This was referenced Jul 25, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #261