Skip to content

fix: stronger and more explicit linter options#267

Merged
tzdybal merged 5 commits intomainfrom
tzdybal/improve_linting
Jul 7, 2022
Merged

fix: stronger and more explicit linter options#267
tzdybal merged 5 commits intomainfrom
tzdybal/improve_linting

Conversation

@tzdybal
Copy link
Copy Markdown
Contributor

@tzdybal tzdybal commented Jan 31, 2022

Resolves #261

@tzdybal tzdybal self-assigned this Jan 31, 2022
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jan 31, 2022

Codecov Report

Merging #267 (e480cb5) into main (8cd8832) will increase coverage by 0.01%.
The diff coverage is 58.82%.

@@            Coverage Diff             @@
##             main     #267      +/-   ##
==========================================
+ Coverage   55.16%   55.18%   +0.01%     
==========================================
  Files          48       48              
  Lines        8802     8800       -2     
==========================================
  Hits         4856     4856              
+ Misses       3193     3191       -2     
  Partials      753      753              
Impacted Files Coverage Δ
block/manager.go 62.46% <ø> (ø)
config/config.go 86.95% <ø> (ø)
da/grpc/mockserv/mockserv.go 82.35% <ø> (ø)
p2p/client.go 62.94% <ø> (ø)
rpc/json/types.go 43.33% <ø> (ø)
state/executor.go 70.79% <ø> (ø)
store/badger.go 91.30% <ø> (ø)
store/kv.go 65.00% <ø> (ø)
store/prefix.go 100.00% <ø> (ø)
store/store.go 63.75% <ø> (ø)
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8cd8832...e480cb5. Read the comment docs.

@adlerjohn
Copy link
Copy Markdown
Contributor

Is this ready for review?

@tzdybal
Copy link
Copy Markdown
Contributor Author

tzdybal commented Feb 2, 2022

No. I wanted to actually fix all the newly exposed linter issues in this PR.

@tzdybal tzdybal force-pushed the tzdybal/improve_linting branch from 97650fa to 4b78bef Compare July 6, 2022 10:43
@tzdybal tzdybal added T:code-hygiene General cleanup and restructuring of code to provide clarity, flexibility, and modularity. and removed no_changelog labels Jul 7, 2022
@tzdybal tzdybal marked this pull request as ready for review July 7, 2022 08:37
@tzdybal tzdybal requested review from adlerjohn and liamsi as code owners July 7, 2022 08:37
@tzdybal tzdybal requested a review from evan-forbes July 7, 2022 08:38
@tzdybal tzdybal merged commit b1df434 into main Jul 7, 2022
@tzdybal tzdybal deleted the tzdybal/improve_linting branch July 7, 2022 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

T:code-hygiene General cleanup and restructuring of code to provide clarity, flexibility, and modularity.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

More strict linter

3 participants