Skip to content

ci: remove duplicate linters#475

Merged
tzdybal merged 1 commit intoevstack:mainfrom
rootulp:rp/duplicate-linters
Jul 27, 2022
Merged

ci: remove duplicate linters#475
tzdybal merged 1 commit intoevstack:mainfrom
rootulp:rp/duplicate-linters

Conversation

@rootulp
Copy link
Copy Markdown
Contributor

@rootulp rootulp commented Jul 25, 2022

Remove duplicate linters and alphabetize list to make it easier to identify duplicates in the future

Comment thread .golangci.yml
enable:
- gofmt
- goimports
- misspell
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gofmt, goimports, misspell are enabled further down in this list

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the duplicates were added in #267

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

Merging #475 (63ea023) into main (b1df434) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #475   +/-   ##
=======================================
  Coverage   55.18%   55.18%           
=======================================
  Files          48       48           
  Lines        8800     8800           
=======================================
  Hits         4856     4856           
  Misses       3191     3191           
  Partials      753      753           

Help us with your feedback. Take ten seconds to tell us how you rate us.

@rootulp rootulp marked this pull request as ready for review July 25, 2022 15:32
Copy link
Copy Markdown
Contributor

@tzdybal tzdybal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch!

Remove duplicate linters and alphabetize list to make it easier to
identify duplicates in the future
@tzdybal tzdybal force-pushed the rp/duplicate-linters branch from 63ea023 to 6244abd Compare July 27, 2022 10:57
@tzdybal tzdybal merged commit 5e77f68 into evstack:main Jul 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants