Skip to content

feat: support Commit gossiping on P2P level#486

Merged
tzdybal merged 2 commits intomainfrom
tzdybal/commit_gossiping
Aug 17, 2022
Merged

feat: support Commit gossiping on P2P level#486
tzdybal merged 2 commits intomainfrom
tzdybal/commit_gossiping

Conversation

@tzdybal
Copy link
Copy Markdown
Contributor

@tzdybal tzdybal commented Aug 2, 2022

This PR introduces Commit gossiping logic. Only the latest commit is interesting for full nodes (as older ones are available in DA).
Work will be continued in future PRs.

Resolves #479.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Aug 2, 2022

Codecov Report

Merging #486 (cf9367a) into main (2ea2334) will decrease coverage by 0.06%.
The diff coverage is 44.18%.

@@            Coverage Diff             @@
##             main     #486      +/-   ##
==========================================
- Coverage   56.15%   56.08%   -0.07%     
==========================================
  Files          50       50              
  Lines        9237     9278      +41     
==========================================
+ Hits         5187     5204      +17     
- Misses       3292     3314      +22     
- Partials      758      760       +2     
Impacted Files Coverage Δ
node/node.go 61.11% <11.76%> (-4.22%) ⬇️
block/manager.go 62.35% <62.50%> (+<0.01%) ⬆️
p2p/client.go 62.91% <66.66%> (-0.04%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@tzdybal tzdybal marked this pull request as ready for review August 3, 2022 10:30
@tzdybal tzdybal self-assigned this Aug 3, 2022
@tzdybal tzdybal requested a review from jbowen93 August 3, 2022 10:32
@Wondertan
Copy link
Copy Markdown
Contributor

In celestia-node we gossip commit along with headers. Is the separation between those a requirement in Optimint?

@tzdybal
Copy link
Copy Markdown
Contributor Author

tzdybal commented Aug 3, 2022

In celestia-node we gossip commit along with headers. Is the separation between those a requirement in Optimint?

No, it's just how I implemented it now. I just thought this way it will be a bit easier and cleaner (no need to have a separate structure just to serialize/deserialize both, etc). Also, theoretically this way full node may pause receiving commits if it's catching up.

@liamsi
Copy link
Copy Markdown
Contributor

liamsi commented Aug 7, 2022

no need to have a separate structure

The structure already exists fwiw: https://github.com/tendermint/tendermint/blob/d68d25dcd5d6a66aa4f9a67bd79e9f09cee84458/types/light.go#L132-L137

@tzdybal tzdybal force-pushed the tzdybal/commit_gossiping branch from 7b3404d to cf9367a Compare August 14, 2022 21:51
@tzdybal tzdybal merged commit 60652ee into main Aug 17, 2022
@tzdybal tzdybal deleted the tzdybal/commit_gossiping branch August 17, 2022 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Block commits gossiping

5 participants