feat: Generate fraud proof after trigger#498
Closed
Manav-Aggarwal wants to merge 6 commits intomanav/fraud_proofsfrom
Closed
feat: Generate fraud proof after trigger#498Manav-Aggarwal wants to merge 6 commits intomanav/fraud_proofsfrom
Manav-Aggarwal wants to merge 6 commits intomanav/fraud_proofsfrom
Conversation
Manav-Aggarwal
changed the title
Manav-Aggarwal
changed the title
Manav-Aggarwal
changed the title
Manav-Aggarwal
requested review from
adlerjohn,
liamsi and
tzdybal
as code owners
Manav-Aggarwal
changed the title
tzdybal
reviewed
Aug 30, 2022
Contributor
tzdybal
left a comment
tzdybal
left a comment
There was a problem hiding this comment.
Left few comments. I need to look at this in IDE ;)
| "github.com/celestiaorg/optimint/types" | ||
| ) | ||
|
|
||
| var fraudProofsEnabled = true |
Contributor
There was a problem hiding this comment.
This shouldn't be global. Please move it to BlockExecutor struct.
| } | ||
|
|
||
| func (e *BlockExecutor) checkFraudProofTrigger(generatedIsr []byte, currentIsrs [][]byte, index int) error { | ||
| func (e *BlockExecutor) checkFraudProofTrigger(generatedIsr []byte, currentIsrs [][]byte, index int) bool { |
Contributor
There was a problem hiding this comment.
Instead of passing [][]byte and index, you can pass element of currentIsrs directly.
jbowen93
added
the
C:state-fraud-proofs
Manav-Aggarwal
commented
Sep 12, 2022
| if len(currentIsrs) != expectedLength { | ||
| return nil, fmt.Errorf("invalid length of ISR list: %d, expected length: %d", len(currentIsrs), expectedLength) | ||
| if fraudProofsEnabled { | ||
| if currentIsrs != nil { |
Member
Author
There was a problem hiding this comment.
add an else here and halt there
Contributor
|
Replaced by #567 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In an optimint full node, after a fraudulent state transition is detected, a Fraud Proof should be generated.
Uses evstack/tendermint#63 for ABCI interface
Closes: #499