Skip to content

Fraud Proofs - one PR to rule them all again#567

Merged
MSevey merged 49 commits intomainfrom
manav/verify_fraud_proof
Nov 17, 2022
Merged

Fraud Proofs - one PR to rule them all again#567
MSevey merged 49 commits intomainfrom
manav/verify_fraud_proof

Conversation

@Manav-Aggarwal
Copy link
Copy Markdown
Member

@Manav-Aggarwal Manav-Aggarwal commented Oct 25, 2022

This PR is just a reference to #538 which consolidates changes made by me, however, it was opened by @tzdybal so he could not approve it. We'll use this PR as a proxy for that PR in order for approval.

Please look at #538 for relevant comments.

Resolves #499, resolves #408, resolves #385, resolves #438, resolves #335

Manav-Aggarwal and others added 30 commits July 5, 2022 16:06
Co-authored-by: Tomasz Zdybał <tomek@zdybal.lap.pl>
Currently we need to use Manav's branch from celestiaorg/tendermint
fork.
@mergify
Copy link
Copy Markdown

mergify Bot commented Oct 27, 2022

⚠️ The sha of the head commit of this PR conflicts with #500. Mergify cannot evaluate rules on this PR. ⚠️

@mergify
Copy link
Copy Markdown

mergify Bot commented Oct 27, 2022

⚠️ The sha of the head commit of this PR conflicts with #500. Mergify cannot evaluate rules on this PR. ⚠️

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Oct 27, 2022

Codecov Report

Merging #567 (5115fd9) into main (7be5aa0) will decrease coverage by 0.81%.
The diff coverage is 44.55%.

@@            Coverage Diff             @@
##             main     #567      +/-   ##
==========================================
- Coverage   55.75%   54.93%   -0.82%     
==========================================
  Files          50       50              
  Lines        9542    10255     +713     
==========================================
+ Hits         5320     5634     +314     
- Misses       3428     3756     +328     
- Partials      794      865      +71     
Impacted Files Coverage Δ
block/manager.go 65.72% <0.00%> (+0.52%) ⬆️
node/node.go 59.82% <16.66%> (-2.45%) ⬇️
types/pb/rollmint/rollmint.pb.go 39.82% <38.18%> (-0.47%) ⬇️
mocks/Application.go 39.37% <46.66%> (+1.68%) ⬆️
state/executor.go 66.42% <58.09%> (-4.38%) ⬇️
p2p/client.go 62.71% <60.00%> (-0.20%) ⬇️
types/serialization.go 68.98% <82.69%> (+2.69%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Comment thread node/integration_test.go
Comment thread state/executor.go Outdated
@MSevey MSevey self-requested a review October 28, 2022 15:56
MSevey
MSevey previously approved these changes Oct 28, 2022
tzdybal
tzdybal previously approved these changes Nov 1, 2022
Copy link
Copy Markdown
Contributor

@tzdybal tzdybal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@Manav-Aggarwal Manav-Aggarwal dismissed stale reviews from tzdybal and MSevey via 306f639 November 17, 2022 19:08
@tzdybal tzdybal requested a review from MSevey November 17, 2022 19:10
tzdybal
tzdybal previously approved these changes Nov 17, 2022
@MSevey MSevey merged commit 8a3780e into main Nov 17, 2022
@MSevey MSevey deleted the manav/verify_fraud_proof branch November 17, 2022 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

4 participants