Validate Fraud Proof and halt chain if needed#500
Closed
Manav-Aggarwal wants to merge 95 commits intomanav/generate_fraudproof_post_FPGMfrom
Closed
Validate Fraud Proof and halt chain if needed#500Manav-Aggarwal wants to merge 95 commits intomanav/generate_fraudproof_post_FPGMfrom
Manav-Aggarwal wants to merge 95 commits intomanav/generate_fraudproof_post_FPGMfrom
Conversation
Bumps [github.com/stretchr/testify](https://github.com/stretchr/testify) from 1.7.2 to 1.7.4. - [Release notes](https://github.com/stretchr/testify/releases) - [Commits](stretchr/testify@v1.7.2...v1.7.4) --- updated-dependencies: - dependency-name: github.com/stretchr/testify dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
* Modified the ApplyBlock method in state/executor.go splitting it into 2 methods. * ApplyBlock which now only validates and executes the block/state * Commit which commits the block * Modifies when blocks are stored in publishBlock in block/manager.go * Create a top level if/else statement that checks if there is a pendingBlock in the manager.store at the next block height. This ensures that if the sequencer crashes during publishBlock (generally during a slow submitBlockToDA call) it will use the already generated pendingBlock as opposed to creating a new block. * Uses the new ApplyBlock/Commit methods to ApplyBlock prior to submitBlockToDA but only Commits the block after successful DA submission. Because ApplyBlock doesn't write to disk a crash is gracefully handled by reapplying the stored pendingBlock with the changes in (2.i) * No longer panics when submitBlockToDA fails after reaching the maximum number of retries. Now returns an error. * Updates github.com/dgraph-io/ristretto (used in Badger DB) to include this change which allows for an Ethermint node to be restarted after crashing on arm64 * Modifies SaveBlock in store/store.go so that it doesn't increment the store's height. Adds SetHeight to store/store.go and calls it immediately after submitBlockToDA within publishBlock in block/manager.go
Bumps [github.com/multiformats/go-multiaddr](https://github.com/multiformats/go-multiaddr) from 0.5.0 to 0.6.0. - [Release notes](https://github.com/multiformats/go-multiaddr/releases) - [Commits](multiformats/go-multiaddr@v0.5.0...v0.6.0) --- updated-dependencies: - dependency-name: github.com/multiformats/go-multiaddr dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [github.com/spf13/cobra](https://github.com/spf13/cobra) from 1.4.0 to 1.5.0. - [Release notes](https://github.com/spf13/cobra/releases) - [Commits](spf13/cobra@v1.4.0...v1.5.0) --- updated-dependencies: - dependency-name: github.com/spf13/cobra dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [github.com/stretchr/testify](https://github.com/stretchr/testify) from 1.7.4 to 1.7.5. - [Release notes](https://github.com/stretchr/testify/releases) - [Commits](stretchr/testify@v1.7.4...v1.7.5) --- updated-dependencies: - dependency-name: github.com/stretchr/testify dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
Because Tendermint encodes ints as strings, and expects strings while decoding, Optimint has to encode int values as strings as well. Resolves #463.
Because Tendermint encodes ints as strings, and expects strings while decoding, Optimint has to encode int values as strings as well. This PR ensures that Tendermint JSON library is used for encoding of results both in plain HTTP requests and JSON RPC requests. Resolves #463.
Do not close channel after subscription cancellation
Bumps [github.com/stretchr/testify](https://github.com/stretchr/testify) from 1.7.5 to 1.8.0. - [Release notes](https://github.com/stretchr/testify/releases) - [Commits](stretchr/testify@v1.7.5...v1.8.0) --- updated-dependencies: - dependency-name: github.com/stretchr/testify dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
….com/stretchr/testify-1.8.0 build(deps): bump github.com/stretchr/testify from 1.7.5 to 1.8.0
…7.1 (#467) Bumps [github.com/libp2p/go-libp2p-pubsub](https://github.com/libp2p/go-libp2p-pubsub) from 0.7.0 to 0.7.1. - [Release notes](https://github.com/libp2p/go-libp2p-pubsub/releases) - [Commits](libp2p/go-libp2p-pubsub@v0.7.0...v0.7.1) --- updated-dependencies: - dependency-name: github.com/libp2p/go-libp2p-pubsub dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* stronger and more explicit linter options * exclude mempool and state/indexer from golangci-lint Co-authored-by: John Adler <adlerjohn@users.noreply.github.com>
Remove duplicate linters and alphabetize list to make it easier to identify duplicates in the future
Move initGenesisChunks call into GetGenesisChunks
mempool was copied from tendermint v0.34.20 It was adapted to make it compatible: - tmsync package was removed (sync used instead) - clist copied to mempool/, imports fixed - v0 removed - v1/reactor.go removed Changes in node, rpc, state packages was caused by changes in mempool API.
modified: mempool/v1/mempool_test.go
Currently we need to use Manav's branch from celestiaorg/tendermint fork.
Co-authored-by: Tomasz Zdybał <tomek@zdybal.lap.pl>
Bumps [github.com/dgraph-io/badger/v3](https://github.com/dgraph-io/badger) from 3.2103.2 to 3.2103.3. - [Release notes](https://github.com/dgraph-io/badger/releases) - [Changelog](https://github.com/dgraph-io/badger/blob/v3.2103.3/CHANGELOG.md) - [Commits](dgraph-io/badger@v3.2103.2...v3.2103.3) --- updated-dependencies: - dependency-name: github.com/dgraph-io/badger/v3 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [github.com/spf13/cobra](https://github.com/spf13/cobra) from 1.5.0 to 1.6.0. - [Release notes](https://github.com/spf13/cobra/releases) - [Commits](spf13/cobra@v1.5.0...v1.6.0) --- updated-dependencies: - dependency-name: github.com/spf13/cobra dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Manav Aggarwal <manavaggarwal1234@gmail.com>
Co-authored-by: Tomasz Zdybał <tomek@zdybal.lap.pl>
Contributor
|
Replaced by #567 |
Ethermint currently imports optimint, so this replace is replacing an unused module currently, testing in rollmint that ethermint works with a specific optimint version. Update the edit so build tests what it should.
Manav-Aggarwal
force-pushed
the
manav/verify_fraud_proof
branch
from
9fbe089 to
9c1bf08
Compare
Codecov Report
@@ Coverage Diff @@
## manav/generate_fraudproof_post_FPGM #500 +/- ##
======================================================================
Coverage ? 55.00%
======================================================================
Files ? 50
Lines ? 10256
Branches ? 0
======================================================================
Hits ? 5641
Misses ? 3752
Partials ? 863 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Contributor
|
Replaced by #567. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
12 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.