-
Notifications
You must be signed in to change notification settings - Fork 260
Rename to rollmint #545
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename to rollmint #545
Changes from all commits
ebcafce
063754c
afb6c3f
2de7d62
b2ac93d
f661cb8
afc4607
857dd06
52cafd5
be462ac
20b1684
e69f2e5
75ee831
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -12,7 +12,7 @@ on: | |
| env: | ||
| REGISTRY: ghcr.io | ||
| IMAGE_NAME: celestiaorg/ethermint | ||
| TAG_PREFIX: optimint- | ||
| TAG_PREFIX: rollmint- | ||
|
|
||
| jobs: | ||
| docker-build: | ||
|
|
@@ -37,16 +37,16 @@ jobs: | |
| with: | ||
| repository: celestiaorg/ethermint | ||
| path: ethermint | ||
| ref: optimint-v0.3.0-rebase | ||
| ref: rollmint-v0.3.0-rebase | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. nit: Can't you use |
||
| - name: Move Stuff and Tidy | ||
| run: | | ||
| ls | ||
| mv ethermint .. | ||
| cd .. | ||
| cp -R optimint ethermint | ||
| cp -R rollmint ethermint | ||
| cd ethermint | ||
| rm -rf .git | ||
| go mod edit -replace=github.com/celestiaorg/optimint=./optimint | ||
| go mod edit -replace=github.com/celestiaorg/rollmint=./rollmint | ||
| go mod tidy -compat=1.17 -e | ||
| - name: Docker meta | ||
| id: meta | ||
|
|
@@ -91,14 +91,14 @@ jobs: | |
| with: | ||
| repository: celestiaorg/ethermint | ||
| path: ethermint | ||
| ref: optimint-v0.3.0-rebase | ||
| ref: rollmint-v0.3.0-rebase | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. same |
||
| - name: Set up Go | ||
| uses: actions/setup-go@v2 | ||
| with: | ||
| go-version: 1.17 | ||
| - name: "Setup Cluster" | ||
| run: | | ||
| export ETHERMINT_IMAGE_TAG=optimint-$(git rev-parse --short "$GITHUB_SHA") | ||
| export ETHERMINT_IMAGE_TAG=rollmint-$(git rev-parse --short "$GITHUB_SHA") | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. same |
||
| echo $ETHERMINT_IMAGE_TAG | ||
| cd ephemeral-cluster | ||
| scripts/minimal-ethermint.sh | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| rollmint | ||
| Copyright 2021-2022 Celestia Labs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: we are renaming it once which means we might rename it again. Or if someone forks this and wants to name it differently they are going to need to find and replace again.
So could we just use a
envvariable up top? LikeDIR_NAME?You could then use that var in a number of places.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Created #546,