Conversation
Codecov Report
@@ Coverage Diff @@
## main #545 +/- ##
==========================================
+ Coverage 55.76% 55.80% +0.04%
==========================================
Files 50 50
Lines 9544 9544
==========================================
+ Hits 5322 5326 +4
+ Misses 3428 3425 -3
+ Partials 794 793 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
@jeremysklaroff added you because of: 2de7d62 |
MSevey
left a comment
MSevey
left a comment
There was a problem hiding this comment.
All my comments are nits really and could be handled in a small follow up if necessary.
| mv ethermint .. | ||
| cd .. | ||
| cp -R optimint ethermint | ||
| cp -R rollmint ethermint |
There was a problem hiding this comment.
nit: we are renaming it once which means we might rename it again. Or if someone forks this and wants to name it differently they are going to need to find and replace again.
So could we just use a env variable up top? Like DIR_NAME?
You could then use that var in a number of places.
| cd "$(dirname "${BASH_SOURCE[0]}")" | ||
|
|
||
| TM_VERSION=v0.34.14 | ||
| TM_VERSION=v0.34.21 |
There was a problem hiding this comment.
My bad. Reverted this change and created: #547
| repeated Event events = 7 | ||
| [(gogoproto.nullable) = false, (gogoproto.jsontag) = "events,omitempty"]; | ||
| string codespace = 8; | ||
| string sender = 9; |
There was a problem hiding this comment.
This doesn't feel like a rename :-)
Is this bringing in some other changes to make the merge easier?
There was a problem hiding this comment.
This is the result of updating TM to 0.34.21. I'll create separate PR for this; I missed this while working on #528.
| repository: celestiaorg/ethermint | ||
| path: ethermint | ||
| ref: optimint-v0.3.0-rebase | ||
| ref: rollmint-v0.3.0-rebase |
There was a problem hiding this comment.
nit: Can't you use TAG_PREFIX here?
| repository: celestiaorg/ethermint | ||
| path: ethermint | ||
| ref: optimint-v0.3.0-rebase | ||
| ref: rollmint-v0.3.0-rebase |
| - name: "Setup Cluster" | ||
| run: | | ||
| export ETHERMINT_IMAGE_TAG=optimint-$(git rev-parse --short "$GITHUB_SHA") | ||
| export ETHERMINT_IMAGE_TAG=rollmint-$(git rev-parse --short "$GITHUB_SHA") |
MSevey
left a comment
MSevey
left a comment
There was a problem hiding this comment.
Docker Github Actions are failing but otherwise looks good
|
Those jobs are expected to fail, sorry for not mentioning this. I need to update cosmos-sdk to use proper version of rollmint, to "fix" those builds. (But I need "rollmint" in the first place) |
3 participants
It's a part of: #535