Conversation
tzdybal
requested review from
MSevey,
Manav-Aggarwal,
jbowen93,
liamsi and
nashqueue
evan-forbes
reviewed
Oct 3, 2022
Contributor
evan-forbes
left a comment
evan-forbes
left a comment
There was a problem hiding this comment.
do we need to regenerate anything? I'm guessing that the tests were failing before as they aren't related
Contributor
Author
|
Tests are failing because there is no compatible version of cosmos-sdk available. My plan was to rename to rollmint, and then release updated cosmos-sdk. I run |
Contributor
Author
|
|
Manav-Aggarwal
approved these changes
Oct 3, 2022
evan-forbes
approved these changes
Oct 3, 2022
During latest Cosmos SDK v0.46.1 update, I forgot to update proto files and script to get them. This PR fixes this.
tzdybal
force-pushed
the
tzdybal/missing_proto
branch
from
1809126 to
702ee5c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During latest Cosmos SDK v0.46.1 update, I forgot to update proto files and script to get them. This PR fixes this.