Skip to content

Remove Commit gossiping logic from P2P client#717

Merged
Manav-Aggarwal merged 1 commit intomainfrom
manav/remove_commit_gossip_logic
Jan 26, 2023
Merged

Remove Commit gossiping logic from P2P client#717
Manav-Aggarwal merged 1 commit intomainfrom
manav/remove_commit_gossip_logic

Conversation

@Manav-Aggarwal
Copy link
Copy Markdown
Member

@Manav-Aggarwal Manav-Aggarwal commented Jan 26, 2023

Since SignedHeaders are gossiped, there is no use for Commit gossiping. Entire related logic should be removed from p2p.Client and node(s).

Closes: #686

@Manav-Aggarwal Manav-Aggarwal changed the title Remove Commit gossiping logic Remove Commit gossiping logic from P2P client Jan 26, 2023
@Manav-Aggarwal Manav-Aggarwal linked an issue Jan 26, 2023 that may be closed by this pull request
@Manav-Aggarwal Manav-Aggarwal self-assigned this Jan 26, 2023
@Manav-Aggarwal Manav-Aggarwal marked this pull request as ready for review January 26, 2023 05:37
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

Base: 55.07% // Head: 55.24% // Increases project coverage by +0.17% 🎉

Coverage data is based on head (d2ad8f6) compared to base (a1643e1).
Patch coverage: 100.00% of modified lines in pull request are covered.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #717      +/-   ##
==========================================
+ Coverage   55.07%   55.24%   +0.17%     
==========================================
  Files          52       52              
  Lines        9851     9814      -37     
==========================================
- Hits         5425     5422       -3     
+ Misses       3618     3590      -28     
+ Partials      808      802       -6     
Impacted Files Coverage Δ
node/full.go 61.96% <ø> (+3.63%) ⬆️
p2p/client.go 60.43% <ø> (-0.30%) ⬇️
block/manager.go 64.31% <100.00%> (+0.51%) ⬆️
state/executor.go 65.54% <0.00%> (+0.72%) ⬆️
types/validation.go 51.16% <0.00%> (+13.95%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Copy Markdown
Contributor

@tzdybal tzdybal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Manav-Aggarwal Manav-Aggarwal merged commit 0c7f5ef into main Jan 26, 2023
@Manav-Aggarwal Manav-Aggarwal deleted the manav/remove_commit_gossip_logic branch January 26, 2023 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove Commit gossiping logic from P2P client

4 participants