Skip to content

[DOCS] Updated compiler-babel.md#7856

Closed
enero-o wants to merge 1 commit intofacebook:masterfrom
enero-o:patch-1
Closed

[DOCS] Updated compiler-babel.md#7856
enero-o wants to merge 1 commit intofacebook:masterfrom
enero-o:patch-1

Conversation

@enero-o
Copy link
Copy Markdown
Contributor

@enero-o enero-o commented Jun 27, 2019

updated how to install babel presets to use the newer namespace conventions.
my react application kept crashing due to the conflict in my babel version "@babel/core": "^7.4.0"

updated how to install babel presets using the newer namescpaced conventions
@facebook-github-bot
Copy link
Copy Markdown
Contributor

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@goodmind
Copy link
Copy Markdown
Contributor

@aiveneh please sign CLA

@enero-o
Copy link
Copy Markdown
Contributor Author

enero-o commented Jun 30, 2019

@goodmind I signed the CLA before creating the PR, I think theres a problem somewhere, sent a mail to cla@fb.com now

@goodmind goodmind closed this Jun 30, 2019
@goodmind goodmind reopened this Jun 30, 2019
@JoelMarcey
Copy link
Copy Markdown
Contributor

I updated the CLA internally and the bot should catch up soon.

@facebook-github-bot
Copy link
Copy Markdown
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

Copy link
Copy Markdown
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mroch is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Copy Markdown
Contributor

@mroch merged this pull request in 71bf6fa.

enero-o added a commit to enero-o/reactjs.org that referenced this pull request Aug 15, 2019
updated how to install babel presets to use the newer namespace conventions that comes with newer versions of Babel, version 7.
My react app kept crashing when I tried installing Flow.
I have updated the docs on Flow's documentation, then I saw the same issue here.

Here is the PR on Flow's docs just in case - facebook/flow#7856
alexkrolick pushed a commit to reactjs/react.dev that referenced this pull request Aug 15, 2019
updated how to install babel presets to use the newer namespace conventions that comes with newer versions of Babel, version 7.
My react app kept crashing when I tried installing Flow.
I have updated the docs on Flow's documentation, then I saw the same issue here.

Here is the PR on Flow's docs just in case - facebook/flow#7856
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants