Skip to content

Update babel packages to new @babel/package #6952

Closed
RibbtDev wants to merge 1 commit intofacebook:masterfrom
RibbtDev:master
Closed

Update babel packages to new @babel/package #6952
RibbtDev wants to merge 1 commit intofacebook:masterfrom
RibbtDev:master

Conversation

@RibbtDev
Copy link
Copy Markdown

I have updated the old package names to the new @babel/__ ones.

The reason:

If you use the old packages with @babel/core v7+ then it gives the error "plugin should return a function not an object".

This change is important as most of the packages are now available in this format. e.g. @babel/preset-react, @babel/preset-env, etc.

Copy link
Copy Markdown
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mroch has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@mroch
Copy link
Copy Markdown
Contributor

mroch commented Jul 17, 2019

whoops, it failed to import.

the babel.md parts of this landed in #7221, which also updated the "presets": ["flow"] line.
one of the two lines in the compiler-babel.md now conflicts, due to #7856 (sorry I saw that one before this one).
#7049 makes a similar fix to use @babel/cli, but also adds @babel/core. i don't know whether it's necessary.
#7933 makes a partial fix to @babel/preset-flow but not @babel/cli.

I'm going to close this one since it needs to be rebased, at least. I'm going to try to resolve all of these this week, though.

@mroch mroch closed this Jul 17, 2019
@goodmind goodmind added the Superseded PRs that solve the same issue as a "superseding" PR that already landed label Jul 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed Superseded PRs that solve the same issue as a "superseding" PR that already landed Website

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants