Fix typo in installation instructions#7933
Fix typo in installation instructions#7933mgmarlow wants to merge 1 commit intofacebook:masterfrom mgmarlow:patch-1
Conversation
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
|
@mgmarlow I thought there already was ton of PRs fixing this, but each next PR finds old babel plugin... Can you sign CLA? |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
|
thanks! @goodmind: there are at least 3 other PRs doing various conflicting things, in various needs of rebasing. #6396 makes a similar change to a different part of the docs, which seems to have already been fixed since this one is current, it seems like the only one that can be merged without conflicts. I think we should probably update to |
|
@mroch sure I'll take a look. I set my project up using rollup so I didn't need the CLI but I can run through a similar flow with those tools. |
|
@mroch You're 100% correct, you also need |
|
awesome, thank you! (and also @KidkArolis and @jeffvandyke for #7049) |
facebook-github-bot
left a comment
There was a problem hiding this comment.
@mroch has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Installation instructions for babel + NPM instructed installing the incorrect babel plugin.