-
Notifications
You must be signed in to change notification settings - Fork 25.1k
Controlled TextInput broken for Chinese (and other languages) in v0.54 on iOS #18403
Copy link
Copy link
Closed
Labels
Component: TextInputRelated to the TextInput component.Related to the TextInput component.Impact: RegressionDescribes a behavior that used to work on a prior release, but stopped working recently.Describes a behavior that used to work on a prior release, but stopped working recently.Issue: Author Provided ReproThis issue can be reproduced in Snack or an attached project.This issue can be reproduced in Snack or an attached project.Platform: iOSiOS applications.iOS applications.Ran CommandsOne of our bots successfully processed a command.One of our bots successfully processed a command.Resolution: FixedA PR that fixes this issue has been merged.A PR that fixes this issue has been merged.Resolution: LockedThis issue was locked by the bot.This issue was locked by the bot.
Description
Metadata
Metadata
Assignees
Labels
Component: TextInputRelated to the TextInput component.Related to the TextInput component.Impact: RegressionDescribes a behavior that used to work on a prior release, but stopped working recently.Describes a behavior that used to work on a prior release, but stopped working recently.Issue: Author Provided ReproThis issue can be reproduced in Snack or an attached project.This issue can be reproduced in Snack or an attached project.Platform: iOSiOS applications.iOS applications.Ran CommandsOne of our bots successfully processed a command.One of our bots successfully processed a command.Resolution: FixedA PR that fixes this issue has been merged.A PR that fixes this issue has been merged.Resolution: LockedThis issue was locked by the bot.This issue was locked by the bot.
Type
Fields
Give feedbackNo fields configured for issues without a type.
Controlled
TextInputbreaks the Chinese pinyin keyboard's autocomplete feature. A similar issue was raised a year and a half ago (#8265) and fixed by #7496. However, it appears that others are having the same problem (#12599, #18260, #18379), but re-filing the issue with the template filled out and an example to reproduce.Note that this works correctly in v0.53. This may have something to do with the big
Text,TextInputrefactor that dropped with v0.54 (Thanks, btw, @shergin and @hovox!).I've included both a working (v0.53) and broken (v0.54) example below.
Environment
Environment:
OS: macOS High Sierra 10.13
Node: 9.3.0
Yarn: 1.3.2
npm: 5.6.0
Watchman: 4.9.0
Xcode: Xcode 9.2 Build version 9C40b
Android Studio: Not Found
Packages: (wanted => installed)
react: 16.2.0 => 16.2.0
react-native: 0.54.0 => 0.54.0
Expected Behavior
Typing on a US keyboard would bring up Chinese characters corresponding to letters typed.
Actual Behavior
Each new letter typed is considered individually, instead of along with the previous untranslated characters.
Shamelessly stealing an image from @Foru who did a nice job of showing the issue:
Steps to Reproduce
Unfortunately, expo hasn't updated to the latest version of React Native. I've prepared a small project that demonstrates the issue here. There is a working version on a branch here; same project, just using RN v0.53 instead of v0.54.