Docs/Tutorial: Highlighting the correct line#17
Merged
zpao merged 1 commit intofacebook:masterfrom May 30, 2013
Merged
Conversation
Member
|
Good catch! |
zpao
added a commit
that referenced
this pull request
May 30, 2013
Docs/Tutorial: Highlighting the correct line
jgebhardt
added a commit
to jgebhardt/react
that referenced
this pull request
Feb 24, 2014
jgebhardt
added a commit
to jgebhardt/react
that referenced
this pull request
Feb 24, 2014
sophiebits
pushed a commit
that referenced
this pull request
Feb 24, 2014
sophiebits
pushed a commit
that referenced
this pull request
Feb 24, 2014
georgesisco
added a commit
to georgesisco/react
that referenced
this pull request
Apr 9, 2014
… steps The following steps also have an ajax function, but the 'error:' param is gone after facebook#13: facebook#14 facebook#17 facebook#19 facebook#20 This may be superfluous, but it helped me find an error with something I was doing - Namely, in my .json file, I had single line javascript comments ("//") that I copied from the tutorial. I couldn't find the issue on later steps, but was able to see my issue when the error handler complained about an unexpected "/" in my file in step facebook#13.
zpao
pushed a commit
that referenced
this pull request
May 8, 2014
The following steps also have an ajax function, but the 'error:' param is gone after #13: #14 #17 #19 #20 This may be superfluous, but it helped me find an error with something I was doing - Namely, in my .json file, I had single line javascript comments ("//") that I copied from the tutorial. I couldn't find the issue on later steps, but was able to see my issue when the error handler complained about an unexpected "/" in my file in step #13.
aickin
added a commit
to aickin/react
that referenced
this pull request
Apr 6, 2016
goatslacker
pushed a commit
to goatslacker/react
that referenced
this pull request
Apr 22, 2016
lunaruan
referenced
this pull request
in bvaughn/react
Jun 15, 2021
Downgrade package-lock.json to lockfileVersion 1 to support Node 14.9
josephsavona
pushed a commit
to josephsavona/react
that referenced
this pull request
Mar 19, 2026
…d InferReactiveScopeVariables passes Ported passes facebook#17-facebook#19 from TypeScript. InferReactivePlaces implements reactivity propagation with post-dominator frontier analysis. RewriteInstructionKindsBasedOnReassignment handles StoreLocal-to-Reassign rewriting. InferReactiveScopeVariables assigns reactive scopes to identifiers. Pass-level results: InferReactivePlaces 951/1169, RewriteInstructionKinds 943/951, InferReactiveScopeVariables 112/943.
switz
added a commit
to switz/react
that referenced
this pull request
Mar 25, 2026
…roughput (facebook#17) The props were the entire bottleneck. 226 client boundaries × ~1.2 KB of serialized props = 227 KB of hydration scripts, capping throughput at ~121 req/s (same as full pipeline). Changes: - renderClientBoundary: skip serializeProps, emit empty props placeholder - flushCompletedQueues: emit one consolidated <script data-fused-hydration> instead of 226 individual scripts. Format: {m: [moduleUrls], b: [[id, moduleIdx]]} - Module ref deduplication in consolidated script Results at c=25 (226-product PLP): Full pipeline: 92 req/s, p50=205ms, heap 193MB Fused renderer: 327 req/s, p50=3.2ms, heap 40MB (3.6x faster) At c=1: Full pipeline: 131 req/s Fused renderer: 576 req/s (4.4x faster, exceeds Fizz-only ceiling) Props delivery to the client is deferred to the hydration strategy (TIM-485). The server emits markers + module refs. The client will get props via DOM extraction, lazy fetch, or a future compact format.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.