Provide grunt npm:test for verifying NPM package functionality#20
Merged
benjamn merged 1 commit intofacebook:masterfrom May 31, 2013
Merged
Conversation
Member
There was a problem hiding this comment.
This is already available at grunt.config.data.pkg
This basically calls `npm pack`, installs the resulting package in a temporary directory, then requires it and attempts to use the .transform method. Closes facebook#12.
benjamn
added a commit
that referenced
this pull request
May 31, 2013
Provide `grunt npm:test` for verifying NPM package functionality
georgesisco
added a commit
to georgesisco/react
that referenced
this pull request
Apr 9, 2014
… steps The following steps also have an ajax function, but the 'error:' param is gone after facebook#13: facebook#14 facebook#17 facebook#19 facebook#20 This may be superfluous, but it helped me find an error with something I was doing - Namely, in my .json file, I had single line javascript comments ("//") that I copied from the tutorial. I couldn't find the issue on later steps, but was able to see my issue when the error handler complained about an unexpected "/" in my file in step facebook#13.
zpao
pushed a commit
that referenced
this pull request
May 8, 2014
The following steps also have an ajax function, but the 'error:' param is gone after #13: #14 #17 #19 #20 This may be superfluous, but it helped me find an error with something I was doing - Namely, in my .json file, I had single line javascript comments ("//") that I copied from the tutorial. I couldn't find the issue on later steps, but was able to see my issue when the error handler complained about an unexpected "/" in my file in step #13.
vjeux
added a commit
that referenced
this pull request
Jul 28, 2014
lunaruan
pushed a commit
to bvaughn/react
that referenced
this pull request
Jun 15, 2021
unstubbable
pushed a commit
to unstubbable/react
that referenced
this pull request
Jan 23, 2026
josephsavona
pushed a commit
to josephsavona/react
that referenced
this pull request
Mar 20, 2026
Ported MemoizeFbtAndMacroOperandsInSameScope (facebook#20) from TypeScript to Rust. Two-phase pass: forward data-flow to identify fbt/macro tags including property chains, then reverse data-flow to merge operand scopes into the macro call's scope. Added custom_macros config support. Zero new test failures.
switz
added a commit
to switz/react
that referenced
this pull request
Mar 25, 2026
…mat (facebook#20) Replace custom resolveClientComponent with standard bundler protocol: - bundlerConfig is the client manifest (same object as Flight's webpackMap) - Module resolution via __webpack_require__(metadata.id) — same as Flight client - Hydration data uses Flight's module ref format: [id, chunks, name, props] - Emitted as self.__FUSED={b:{...}} — parseable by existing RSC client runtime Per-request: 7.33ms (full pipeline) → 4.78ms (fused) = 1.5x faster Concurrent throughput improvement reduced by props serialization output volume (451 KB fused vs 120 KB full pipeline). The CPU savings from eliminating Flight are real but offset by generating 3.7x more bytes. Next step: investigate reducing props output volume to recover the concurrent throughput advantage.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This basically calls
npm pack, installs the resulting package in a temporary directory, then requires it and attempts to use the.transformmethod. Bonus:bin/jsx main.js.The
npm pack .command takes a long time on my machine. When I run it manually with--verbose, it seems to be hanging on thenpm verb lockline, so it seems to be annpmproblem.Closes #12.