Wire up createViewTransitionInstance and suspendOnActiveViewTransition in Fabric#36196
Merged
zeyap merged 5 commits intofacebook:mainfrom Apr 16, 2026
Merged
Conversation
Extract the tag allocation logic into a shared `allocateTag()` function in ReactFiberConfigFabric and use it in both `createInstance`/`createTextInstance` and `createViewTransitionInstance` in the ViewTransition config. Also wire up the native `fabricCreateViewTransitionInstance` call.
|
Comparing: fe51601...f0825fe Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: (No significant changes) |
…wTransitionInstance
Import suspendOnActiveViewTransition from nativeFabricUIManager and call it inside the Fabric renderer's suspendOnActiveViewTransition export.
Fix prop-missing Flow error by adding the missing property declaration.
jackpope
approved these changes
Apr 16, 2026
eps1lon
pushed a commit
to vercel/next.js
that referenced
this pull request
Apr 20, 2026
[diff facebook/react@fef12a01...da9325b5](facebook/react@fef12a0...da9325b) <details> <summary>React upstream changes</summary> - facebook/react#35962 - facebook/react#35961 - facebook/react#36277 - facebook/react#36297 - facebook/react#36292 - facebook/react#36291 - facebook/react#36196 - facebook/react#36246 - facebook/react#36287 - facebook/react#36285 - facebook/react#36274 - facebook/react#36266 - facebook/react#36253 </details>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fabricCreateViewTransitionInstancecall increateViewTransitionInstancewhich will create a ShadowNode for old pseudo elementallocateTag()function exported fromReactFiberConfigFabricallocateTaginReactFiberConfigFabricWithViewTransitionallocateTag()increateInstanceandcreateTextInstanceinstead of inline tag incrementingfabricSuspendOnActiveViewTransitioncall insuspendOnActiveViewTransitionwhich suspends another view transition when the previous one is not yet finishedTest plan