[test] Make enableSuspenseyImages dynamic#36274
Merged
eps1lon merged 1 commit intofacebook:mainfrom Apr 15, 2026
Merged
Conversation
This flag was off everywhere which meant we didn't test the Suspensey commit phase anymore. As an alternative, we could've converted the SuspenseyCommit test to using resources but that requires implementing a lot more host config options (`packages/react-noop-renderer/src/ReactFiberConfigNoopResources.js`).
github-actions
Bot
added
the
React Core Team
rickhanlonii
approved these changes
Apr 15, 2026
eps1lon
deleted the
sebbie/04-15-_test_make_enablesuspenseyimages_dynamic
branch
github-actions Bot
pushed a commit
to code/lib-react
that referenced
this pull request
Apr 19, 2026
DiffTrain build for [00f063c](facebook@00f063c)
github-actions Bot
pushed a commit
to code/lib-react
that referenced
this pull request
Apr 19, 2026
DiffTrain build for [00f063c](facebook@00f063c)
eps1lon
pushed a commit
to vercel/next.js
that referenced
this pull request
Apr 20, 2026
[diff facebook/react@fef12a01...da9325b5](facebook/react@fef12a0...da9325b) <details> <summary>React upstream changes</summary> - facebook/react#35962 - facebook/react#35961 - facebook/react#36277 - facebook/react#36297 - facebook/react#36292 - facebook/react#36291 - facebook/react#36196 - facebook/react#36246 - facebook/react#36287 - facebook/react#36285 - facebook/react#36274 - facebook/react#36266 - facebook/react#36253 </details>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This flag was off everywhere which meant we didn't test the Suspensey commit phase anymore.
As an alternative, we could've converted the SuspenseyCommit test to using resources but that requires implementing a lot more host config options (
packages/react-noop-renderer/src/ReactFiberConfigNoopResources.js).