Added link about personal identity#86
Merged
williamkapke merged 2 commits intonodejs:masterfrom Apr 6, 2016
Merged
Conversation
| @@ -40,11 +40,11 @@ for the Node.js project: | |||
| Its responsibilites are: | |||
Contributor
There was a problem hiding this comment.
Can you add a comment here like:
<!--
This information should mostly mirror:
https://github.com/nodejs/inclusivity/blob/master/README.md#list-of-responsibilities
-->
Also, consider doing a PR to inclusivity/README.md with comments to help any possible future changes get propagated to the mirrors.
Contributor
|
Seems like a great compromise! LGTM with the nit about adding a comment. |
Contributor
Author
|
I added links to the responsibilities and purpose, PTAL |
Contributor
|
LGTM! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While reviewing nodejs/nodejs.org#623, I noticed that the list of identity traits was removed from the list of responsibilities for the Inclusivity WG section from TSC/WORKING_GROUPS.md that is present in inclusivity/README.md.
I think this list of identities is important for understanding what this responsibility means, but at the same time I understand how much length it adds to the document and why it was removed.
As a compromise, I added a link to the Inclusivity WG's section on responsibilities so that people can discover the list and the full meaning of this responsibility without bloating the length of this document.