chore: replace var with const/let in repo#119
Merged
aeschright merged 1 commit intonpm:release-nextfrom Jan 9, 2019
Merged
Conversation
watilde
changed the title
Contributor
|
Please split this up into two PRs. I can take the docs PRs more easily than code ones, too. |
watilde
force-pushed
the
feature/let-const
branch
from
0edf0bd to
0b1e09e
Compare
Contributor
Author
|
I just splitted into the two here and #120. |
aeschright
pushed a commit
that referenced
this pull request
Jan 10, 2019
PR-URL: #119 Credit: @watilde Reviewed-By: @aeschright
aeschright
added a commit
that referenced
this pull request
Jan 10, 2019
This reverts commit c665f35.
aeschright
pushed a commit
that referenced
this pull request
Jan 18, 2019
PR-URL: #119 Credit: @watilde Reviewed-By: @aeschright
Jah-yee
pushed a commit
to Jah-yee/cli
that referenced
this pull request
Apr 16, 2026
…pm#134) Previously used dirs::config_dir() which resolves to different paths per OS (~/Library/Application Support/gws on macOS, %APPDATA%\gws on Windows), contradicting the documented ~/.config/gws/ path and causing users to place config files in the wrong location (ref npm#119). Now uses ~/.config/gws/ everywhere with a fallback to the legacy OS-specific path for existing installs. Also consolidates duplicated dirs::config_dir() calls in auth.rs and discovery.rs to use the central config_dir() helper.
Jah-yee
pushed a commit
to Jah-yee/cli
that referenced
this pull request
Apr 16, 2026
…#119) (npm#127) Admin-only scopes (apps.*, cloud-identity.*, ediscovery, directory.readonly, groups) require Workspace domain-admin access and cannot be granted to personal @gmail.com accounts — Google returns 400 invalid_scope when they're included. Changes: - Add is_workspace_admin_scope() helper (mirrors is_app_only_scope()) to identify scopes that fail for personal Google accounts - Exclude these scopes from the template_selects of the 'Recommended' preset in run_discovery_scope_picker() - Exclude them from the resolved scope list when the Recommended template is confirmed - Add 8 unit tests covering the new helper Workspace admins can still access these scopes via 'Full Access' template or by selecting them individually in the picker. Note: this is complementary to PR npm#108 which filters alertcenter scopes at the API-discovery level. This PR handles the broader set at the recommendation layer. Addresses npm#119 (Bug 1: admin scopes in Recommended preset) Co-authored-by: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs: https://npm.community/t/replace-var-with-let-const/4083